AramJonghu
AramJonghu commented on pull request zach/z-bar-qt#114 2026-05-31 17:18:31 +02:00
initial refactor of Interactions.qml to add better support for touch screen gestures

Could this value also be a variable that takes a percentage of horizontal pixels on the display (or size of display eg a 14 inch display vs 24 inch).

AramJonghu approved zach/z-bar-qt#114 2026-05-31 17:18:31 +02:00
initial refactor of Interactions.qml to add better support for touch screen gestures

It works well. The only part that is a bit iffy is doing the two finger gesture, especially with a thin border. It was my suggestion to do two fingers, feels a bit bad. Another suggestion could be:

AramJonghu commented on pull request zach/z-bar-qt#104 2026-05-30 22:28:08 +02:00
zshell-img-tools

Rust codebase still has comments. We can create issues resolving the issue I remarked about the binary and code cleanup. Code works fine which for now is fine.

AramJonghu commented on pull request zach/z-bar-qt#104 2026-05-30 21:01:55 +02:00
zshell-img-tools

Lint format failing is because rustfmt is running on rust edition 2015 on base.

I assume you mean 2025?

AramJonghu synced commits to refs/heads/main at AramJonghu/file-organizer from mirror 2026-05-30 15:17:37 +02:00
7a537926fc archives support, builds .exe as well now
AramJonghu synced commits to refs/tags/0.1.2 at AramJonghu/file-organizer from mirror 2026-05-30 15:17:37 +02:00
AramJonghu synced new reference refs/tags/0.1.2 to AramJonghu/file-organizer from mirror 2026-05-30 15:17:37 +02:00
AramJonghu commented on issue zach/z-bar-qt#106 2026-05-30 12:48:36 +02:00
Battery low toast issues

I see that this d6102d9ebe is not main.

AramJonghu commented on issue zach/z-bar-qt#106 2026-05-30 11:18:24 +02:00
Battery low toast issues

I misread, thought it went into another branch.

AramJonghu synced commits to refs/heads/laptop at AramJonghu/hypr from mirror 2026-05-30 01:57:35 +02:00
b6349ceaec touchscreen workspace support, hdr testing
AramJonghu commented on pull request zach/z-bar-qt#104 2026-05-30 00:59:50 +02:00
zshell-img-tools

Swappy was discussed. Not much to do with the complaints. The delay seems exclusive to my laptop. Other things are indeed config related. Shadow limits are considered for the reasons to have…

AramJonghu pushed to format-check-rust-fix at zach/z-bar-qt 2026-05-29 20:14:08 +02:00
a747f21af5 Merge branch 'main' into format-check-rust-fix
d6102d9ebe fix battery popup thresholds firing more than once per charging period
0819e8e2d1 Merge pull request 'format check shows green check, not anymore when format shows fail' (#110) from format-check-rust-fix into main
Compare 3 commits »
AramJonghu created pull request zach/z-bar-qt#112 2026-05-29 20:14:01 +02:00
either fail ? then check fail else pass
AramJonghu created branch format-check-rust-fix in zach/z-bar-qt 2026-05-29 20:12:38 +02:00
AramJonghu pushed to format-check-rust-fix at zach/z-bar-qt 2026-05-29 20:12:38 +02:00
21c6940fb1 either fail ? then check fail else pass
AramJonghu opened issue zach/z-bar-qt#111 2026-05-29 19:02:38 +02:00
Border prevents touchscreen function
AramJonghu commented on pull request zach/z-bar-qt#104 2026-05-29 18:49:54 +02:00
zshell-img-tools

Also resolve the Rust formatting check (it shows checkmark, but in details, it did not pass).

AramJonghu commented on issue zach/z-bar-qt#106 2026-05-29 18:44:09 +02:00
Battery low toast issues

Seems to work, can be closed once #104 is closed.

AramJonghu commented on pull request zach/z-bar-qt#104 2026-05-29 18:42:35 +02:00
zshell-img-tools

cli_args_provided says the same as the comment.

AramJonghu suggested changes for zach/z-bar-qt#104 2026-05-29 18:42:35 +02:00
zshell-img-tools

I do not know rust at all, so code review is limited for rust. I know some basic cpp, but it looked fine. As far as I can read, qml changes are mostly config changes or changes to fit hyprland's changes.