Consider a squash commit since there is a lot of noise with all the commits. A single squash commit would reduce the many commit messages with a single more informative commit message.
I think for consistency and readibility of PRs reasons, I should reserve fixing clang-tidy (and format) for a different PR. That would muddy this PR and add noise.
On further search; we cannot…
Certainly possible. Previous implementation was just a wildcard (so all diagnostics were considered errors). We can pick which diagnostics we want as errors, warnings, or info/help.
@zach Many of the tidy rules are removed and they are not considered errors anymore. I will research further some other day (perhaps when skimming the current tidy warnings in the workflow step)…