AramJonghu

AramJonghu commented on issue zach/z-bar-qt#106

2026-05-30 12:48:36 +02:00

Battery low toast issues

I see that this d6102d9ebe is not main.

AramJonghu commented on issue zach/z-bar-qt#106

2026-05-30 11:18:24 +02:00

Battery low toast issues

I misread, thought it went into another branch.

AramJonghu synced commits to refs/heads/laptop at AramJonghu/hypr from mirror 2026-05-30 01:57:35 +02:00

b6349ceaec touchscreen workspace support, hdr testing

AramJonghu commented on pull request zach/z-bar-qt#104

2026-05-30 00:59:50 +02:00

zshell-img-tools

Swappy was discussed. Not much to do with the complaints. The delay seems exclusive to my laptop. Other things are indeed config related. Shadow limits are considered for the reasons to have…

AramJonghu pushed to format-check-rust-fix at zach/z-bar-qt

2026-05-29 20:14:08 +02:00

a747f21af5 Merge branch 'main' into format-check-rust-fix

d6102d9ebe fix battery popup thresholds firing more than once per charging period

0819e8e2d1 Merge pull request 'format check shows green check, not anymore when format shows fail' (#110) from format-check-rust-fix into main

Compare 3 commits »

AramJonghu created pull request zach/z-bar-qt#112

2026-05-29 20:14:01 +02:00

either fail ? then check fail else pass

AramJonghu pushed to format-check-rust-fix at zach/z-bar-qt

2026-05-29 20:12:38 +02:00

21c6940fb1 either fail ? then check fail else pass

AramJonghu created branch format-check-rust-fix in zach/z-bar-qt

2026-05-29 20:12:38 +02:00

AramJonghu opened issue zach/z-bar-qt#111

2026-05-29 19:02:38 +02:00

Border prevents touchscreen function

AramJonghu commented on pull request zach/z-bar-qt#104

2026-05-29 18:49:54 +02:00

zshell-img-tools

Also resolve the Rust formatting check (it shows checkmark, but in details, it did not pass).

AramJonghu commented on issue zach/z-bar-qt#106

2026-05-29 18:44:09 +02:00

Battery low toast issues

Seems to work, can be closed once #104 is closed.

AramJonghu suggested changes for zach/z-bar-qt#104

2026-05-29 18:42:35 +02:00

zshell-img-tools

I do not know rust at all, so code review is limited for rust. I know some basic cpp, but it looked fine. As far as I can read, qml changes are mostly config changes or changes to fit hyprland's changes.

AramJonghu commented on pull request zach/z-bar-qt#104

2026-05-29 18:42:35 +02:00

zshell-img-tools

cli_args_provided says the same as the comment.

AramJonghu commented on pull request zach/z-bar-qt#104

2026-05-29 18:42:35 +02:00

zshell-img-tools

This is a nitpick, perhaps a pet peeve of mine; Is it not obvious that shadow_img is a shadow above at line 94? If you need a comment for the contents of pixmap_to_rgba_image, then do the contents not need better naming to reflect its function?

AramJonghu commented on pull request zach/z-bar-qt#104

2026-05-29 18:42:35 +02:00

zshell-img-tools

Should the default value of screenshot effects be enabled? I can see a reason for either option.

AramJonghu commented on issue zach/z-bar-qt#106

2026-05-29 13:03:41 +02:00

Battery low toast issues

Will drain battery and try.

AramJonghu synced commits to refs/heads/master at AramJonghu/aramjonghu-site from mirror 2026-05-29 06:07:37 +02:00

fe9e9082b2 useState reduntant call removed, a project replaced

AramJonghu commented on issue zach/z-bar-qt#106

2026-05-29 00:59:12 +02:00

Battery low toast issues

The commit in question: 8e14993633

Notification showed up at 20% this time. Each percent added another…

AramJonghu deleted branch 100-cli-autocompletion from zach/z-bar-qt

2026-05-29 00:55:19 +02:00

AramJonghu created pull request zach/z-bar-qt#110

2026-05-29 00:20:39 +02:00

format check shows green check, not anymore when format shows fail