clang-tidy fixes incoming

Reviewed-on: #117

.clang-tidy

@@ -24,8 +24,7 @@ CheckOptions:
     readability-identifier-naming.StaticConstantCase: UPPER_CASE
     readability-identifier-naming.StaticConstantPrefix: k
     readability-identifier-naming.VariableCase: camelBack
-WarningsAsErrors: "*"
-HeaderFilterRegex: ".*"
+HeaderFilterRegex: ""
 FormatStyle: file
 
 ...

Drawers/Interactions.qml

@@ -69,14 +69,17 @@ Item {
 				root.singleGestureTriggered = false;
 		}
 		onCentroidChanged: {
-			if (root.singleGestureTriggered)
-				return;
-
 			const x = centroid.position.x;
 			const y = centroid.position.y;
 			const dragX = x - centroid.pressPosition.x;
 			const dragY = y - centroid.pressPosition.y;
 
+			if (centroid.pressPosition.y >= root.screen.height - Config.barConfig.border && dragY < -200)
+				root.visibilities.launcher = true;
+
+			if (root.singleGestureTriggered)
+				return;
+
 			if (centroid.pressPosition.y < root.bar.implicitHeight) {
 				if (dragY > 20) {
 					root.visibilities.settings = true;

Modules/Clock.qml

@@ -23,7 +23,7 @@ CustomRect {
 
 		anchors.centerIn: parent
 		color: root.visibilities.dashboard ? DynamicColors.palette.m3onPrimary : DynamicColors.palette.m3onSurface
-		font: Appearance.font.family.mono
+		font: Appearance.font.family.mono // qmllint disable incompatible-type
 		text: Time.dateStr
 
 		Behavior on color {

Modules/SysTray/Widgets/UPowerWidget.qml

@@ -28,8 +28,6 @@ Item {
 
 			spacing: 1
 
-			Component.onCompleted: console.log(Battery.isLaptop)
-
 			CustomRect {
 				id: track
 

Plugins/ZShell/Blobs/blobgroup.hpp

@@ -18,13 +18,13 @@ public:
 explicit BlobGroup(QObject* parent = nullptr);
 ~BlobGroup() override;
 
-qreal smoothing() const {
+[[nodiscard]] qreal smoothing() const {
 	return m_smoothing;
 }
 
 void setSmoothing(qreal s);
 
-QColor color() const {
+[[nodiscard]] QColor color() const {
 	return m_color;
 }
 
@@ -36,11 +36,11 @@ void removeShape(BlobShape* shape);
 void setInvertedRect(BlobInvertedRect* rect);
 void clearInvertedRect(BlobInvertedRect* rect);
 
-const QList<BlobShape*>& shapes() const {
+[[nodiscard]] const QList<BlobShape*>& shapes() const {
 	return m_shapes;
 }
 
-BlobInvertedRect* invertedRect() const {
+[[nodiscard]] BlobInvertedRect* invertedRect() const {
 	return m_invertedRect;
 }
 

Plugins/ZShell/Blobs/blobinvertedrect.hpp

@@ -16,25 +16,25 @@ public:
 explicit BlobInvertedRect(QQuickItem* parent = nullptr);
 ~BlobInvertedRect() override;
 
-qreal borderLeft() const {
+[[nodiscard]] qreal borderLeft() const {
 	return m_borderLeft;
 }
 
 void setBorderLeft(qreal v);
 
-qreal borderRight() const {
+[[nodiscard]] qreal borderRight() const {
 	return m_borderRight;
 }
 
 void setBorderRight(qreal v);
 
-qreal borderTop() const {
+[[nodiscard]] qreal borderTop() const {
 	return m_borderTop;
 }
 
 void setBorderTop(qreal v);
 
-qreal borderBottom() const {
+[[nodiscard]] qreal borderBottom() const {
 	return m_borderBottom;
 }
 
@@ -47,7 +47,7 @@ void borderTopChanged();
 void borderBottomChanged();
 
 protected:
-bool isInvertedRect() const override {
+[[nodiscard]] bool isInvertedRect() const override {
 	return true;
 }
 

Plugins/ZShell/Blobs/blobmaterial.hpp

@@ -21,8 +21,8 @@ struct BlobRectData {
 
 class BlobMaterial : public QSGMaterial {
 public:
-QSGMaterialType* type() const override;
-QSGMaterialShader* createShader(QSGRendererInterface::RenderMode) const override;
+[[nodiscard]] QSGMaterialType* type() const override;
+[[nodiscard]] QSGMaterialShader* createShader(QSGRendererInterface::RenderMode) const override;
 int compare(const QSGMaterial* other) const override;
 
 float m_paddedX = 0;

Plugins/ZShell/Blobs/blobrect.hpp

@@ -24,7 +24,7 @@ public:
 explicit BlobRect(QQuickItem* parent = nullptr);
 ~BlobRect() override;
 
-qreal stiffness() const {
+[[nodiscard]] qreal stiffness() const {
 	return m_stiffness;
 }
 
@@ -35,7 +35,7 @@ void setStiffness(qreal s) {
 	}
 }
 
-qreal damping() const {
+[[nodiscard]] qreal damping() const {
 	return m_damping;
 }
 
@@ -46,7 +46,7 @@ void setDamping(qreal d) {
 	}
 }
 
-qreal deformScale() const {
+[[nodiscard]] qreal deformScale() const {
 	return m_deformScale;
 }
 
@@ -62,25 +62,25 @@ QQmlListProperty<BlobRect> exclude();
 bool isExcluded(const BlobShape* other) const override;
 void cornerRadii(float out[4]) const override;
 
-qreal topLeftRadius() const {
+[[nodiscard]] qreal topLeftRadius() const {
 	return m_topLeftRadius;
 }
 
 void setTopLeftRadius(qreal r);
 
-qreal topRightRadius() const {
+[[nodiscard]] qreal topRightRadius() const {
 	return m_topRightRadius;
 }
 
 void setTopRightRadius(qreal r);
 
-qreal bottomLeftRadius() const {
+[[nodiscard]] qreal bottomLeftRadius() const {
 	return m_bottomLeftRadius;
 }
 
 void setBottomLeftRadius(qreal r);
 
-qreal bottomRightRadius() const {
+[[nodiscard]] qreal bottomRightRadius() const {
 	return m_bottomRightRadius;
 }
 

Plugins/ZShell/Blobs/blobshape.hpp

@@ -21,23 +21,23 @@ public:
 explicit BlobShape(QQuickItem* parent = nullptr);
 ~BlobShape() override = default;
 
-BlobGroup* group() const {
+[[nodiscard]] BlobGroup* group() const {
 	return m_group;
 }
 
 void setGroup(BlobGroup* g);
 
-qreal radius() const {
+[[nodiscard]] qreal radius() const {
 	return m_radius;
 }
 
 void setRadius(qreal r);
 
-QMatrix4x4 deformMatrix() const {
+[[nodiscard]] QMatrix4x4 deformMatrix() const {
 	return m_centeredDeformMatrix;
 }
 
-QMatrix4x4 rawDeformMatrix() const {
+[[nodiscard]] QMatrix4x4 rawDeformMatrix() const {
 	return m_deformMatrix;
 }
 
@@ -53,7 +53,7 @@ void geometryChange(const QRectF& newGeometry, const QRectF& oldGeometry) overri
 void updatePolish() override;
 QSGNode* updatePaintNode(QSGNode* oldNode, UpdatePaintNodeData*) override;
 
-virtual bool isInvertedRect() const {
+[[nodiscard]] virtual bool isInvertedRect() const {
 	return false;
 }
 
@@ -72,10 +72,9 @@ void updateCenteredDeformMatrix();
 
 BlobGroup* m_group = nullptr;
 qreal m_radius = 0;
-QMatrix4x4 m_deformMatrix;     // identity by default
+QMatrix4x4 m_deformMatrix;
 QMatrix4x4 m_centeredDeformMatrix;
 
-// Cached data from updatePolish
 float m_cachedPaddedX = 0;
 float m_cachedPaddedY = 0;
 float m_cachedPaddedW = 0;
@@ -84,10 +83,10 @@ QRectF m_localPaddedRect;
 QVector<BlobRectData> m_cachedRects;
 int m_cachedMyIndex = -2;
 float m_pendingDx = 0;
-	float m_pendingDy = 0;
-	float m_pendingDw = 0;
-	float m_pendingDh = 0;
-	bool m_cachedHasInverted = false;
+float m_pendingDy = 0;
+float m_pendingDw = 0;
+float m_pendingDh = 0;
+bool m_cachedHasInverted = false;
 float m_cachedInvertedRadius = 0;
 float m_cachedInvertedOuter[4] = {};
 float m_cachedInvertedInner[4] = {};

Plugins/ZShell/Internal/arcgauge.hpp

@@ -58,4 +58,4 @@ qreal m_sweepAngle = 1.5 * M_PI;
 qreal m_lineWidth = 10.0;
 };
 
-} // namespace ZShell::internal
+} // namespace ZShell::Internal

Plugins/ZShell/Internal/cachingimagemanager.hpp

@@ -7,59 +7,60 @@
 namespace ZShell::internal {
 
 class CachingImageManager : public QObject {
-    Q_OBJECT
-    QML_ELEMENT
+Q_OBJECT
+QML_ELEMENT
 
-    Q_PROPERTY(QQuickItem* item READ item WRITE setItem NOTIFY itemChanged REQUIRED)
-    Q_PROPERTY(QUrl cacheDir READ cacheDir WRITE setCacheDir NOTIFY cacheDirChanged REQUIRED)
+Q_PROPERTY(QQuickItem* item READ item WRITE setItem NOTIFY itemChanged REQUIRED)
+Q_PROPERTY(QUrl cacheDir READ cacheDir WRITE setCacheDir NOTIFY cacheDirChanged REQUIRED)
 
-    Q_PROPERTY(QString path READ path WRITE setPath NOTIFY pathChanged)
-    Q_PROPERTY(QUrl cachePath READ cachePath NOTIFY cachePathChanged)
+Q_PROPERTY(QString path READ path WRITE setPath NOTIFY pathChanged)
+Q_PROPERTY(QUrl cachePath READ cachePath NOTIFY cachePathChanged)
 
 public:
-    explicit CachingImageManager(QObject* parent = nullptr)
-        : QObject(parent)
-        , m_item(nullptr) {}
+explicit CachingImageManager(QObject* parent = nullptr)
+	: QObject(parent)
+	, m_item(nullptr) {
+}
 
-    [[nodiscard]] QQuickItem* item() const;
-    void setItem(QQuickItem* item);
+[[nodiscard]] QQuickItem* item() const;
+void setItem(QQuickItem* item);
 
-    [[nodiscard]] QUrl cacheDir() const;
-    void setCacheDir(const QUrl& cacheDir);
+[[nodiscard]] QUrl cacheDir() const;
+void setCacheDir(const QUrl& cacheDir);
 
-    [[nodiscard]] QString path() const;
-    void setPath(const QString& path);
+[[nodiscard]] QString path() const;
+void setPath(const QString& path);
 
-    [[nodiscard]] QUrl cachePath() const;
+[[nodiscard]] QUrl cachePath() const;
 
-    Q_INVOKABLE void updateSource();
-    Q_INVOKABLE void updateSource(const QString& path);
+Q_INVOKABLE void updateSource();
+Q_INVOKABLE void updateSource(const QString& path);
 
 signals:
-    void itemChanged();
-    void cacheDirChanged();
+void itemChanged();
+void cacheDirChanged();
 
-    void pathChanged();
-    void cachePathChanged();
-    void usingCacheChanged();
+void pathChanged();
+void cachePathChanged();
+void usingCacheChanged();
 
 private:
-    QString m_shaPath;
+QString m_shaPath;
 
-    QQuickItem* m_item;
-    QUrl m_cacheDir;
+QQuickItem* m_item;
+QUrl m_cacheDir;
 
-    QString m_path;
-    QUrl m_cachePath;
+QString m_path;
+QUrl m_cachePath;
 
-    QMetaObject::Connection m_widthConn;
-    QMetaObject::Connection m_heightConn;
+QMetaObject::Connection m_widthConn;
+QMetaObject::Connection m_heightConn;
 
-    [[nodiscard]] qreal effectiveScale() const;
-    [[nodiscard]] QSize effectiveSize() const;
+[[nodiscard]] qreal effectiveScale() const;
+[[nodiscard]] QSize effectiveSize() const;
 
-    void createCache(const QString& path, const QString& cache, const QString& fillMode, const QSize& size) const;
-    [[nodiscard]] static QString sha256sum(const QString& path);
+void createCache(const QString& path, const QString& cache, const QString& fillMode, const QSize& size) const;
+[[nodiscard]] static QString sha256sum(const QString& path);
 };
 
 } // namespace ZShell::internal

Plugins/ZShell/Internal/circularbuffer.cpp

@@ -2,7 +2,7 @@
 
 #include <algorithm>
 
-namespace caelestia::internal {
+namespace ZShell::internal {
 
 CircularBuffer::CircularBuffer(QObject* parent)
 	: QObject(parent) {
@@ -92,4 +92,4 @@ qreal CircularBuffer::at(int index) const {
 	return m_data[actualIndex];
 }
 
-} // namespace caelestia::internal
+} // namespace ZShell::internal

Plugins/ZShell/Internal/circularbuffer.hpp

@@ -4,7 +4,7 @@
 #include <qqmlintegration.h>
 #include <qvector.h>
 
-namespace caelestia::internal {
+namespace ZShell::internal {
 
 class CircularBuffer : public QObject {
 Q_OBJECT
@@ -41,4 +41,4 @@ int m_count = 0;
 int m_capacity = 0;
 };
 
-} // namespace caelestia::internal
+} // namespace ZShell::internal

Plugins/ZShell/Internal/circularindicatormanager.hpp

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <cstdint>
 #include <qeasingcurve.h>
 #include <qobject.h>
 #include <qqmlintegration.h>

Plugins/ZShell/Internal/hyprdevices.hpp

@@ -8,67 +8,67 @@
 namespace ZShell::internal::hypr {
 
 class HyprKeyboard : public QObject {
-    Q_OBJECT
-    QML_ELEMENT
-    QML_UNCREATABLE("HyprKeyboard instances can only be retrieved from a HyprDevices")
+Q_OBJECT
+QML_ELEMENT
+        QML_UNCREATABLE("HyprKeyboard instances can only be retrieved from a HyprDevices")
 
-    Q_PROPERTY(QVariantHash lastIpcObject READ lastIpcObject NOTIFY lastIpcObjectChanged)
-    Q_PROPERTY(QString address READ address NOTIFY addressChanged)
-    Q_PROPERTY(QString name READ name NOTIFY nameChanged)
-    Q_PROPERTY(QString layout READ layout NOTIFY layoutChanged)
-    Q_PROPERTY(QString activeKeymap READ activeKeymap NOTIFY activeKeymapChanged)
-    Q_PROPERTY(bool capsLock READ capsLock NOTIFY capsLockChanged)
-    Q_PROPERTY(bool numLock READ numLock NOTIFY numLockChanged)
-    Q_PROPERTY(bool main READ main NOTIFY mainChanged)
+Q_PROPERTY(QVariantHash lastIpcObject READ lastIpcObject NOTIFY lastIpcObjectChanged)
+Q_PROPERTY(QString address READ address NOTIFY addressChanged)
+Q_PROPERTY(QString name READ name NOTIFY nameChanged)
+Q_PROPERTY(QString layout READ layout NOTIFY layoutChanged)
+Q_PROPERTY(QString activeKeymap READ activeKeymap NOTIFY activeKeymapChanged)
+Q_PROPERTY(bool capsLock READ capsLock NOTIFY capsLockChanged)
+Q_PROPERTY(bool numLock READ numLock NOTIFY numLockChanged)
+Q_PROPERTY(bool main READ main NOTIFY mainChanged)
 
 public:
-    explicit HyprKeyboard(QJsonObject ipcObject, QObject* parent = nullptr);
+explicit HyprKeyboard(QJsonObject ipcObject, QObject* parent = nullptr);
 
-    [[nodiscard]] QVariantHash lastIpcObject() const;
-    [[nodiscard]] QString address() const;
-    [[nodiscard]] QString name() const;
-    [[nodiscard]] QString layout() const;
-    [[nodiscard]] QString activeKeymap() const;
-    [[nodiscard]] bool capsLock() const;
-    [[nodiscard]] bool numLock() const;
-    [[nodiscard]] bool main() const;
+[[nodiscard]] QVariantHash lastIpcObject() const;
+[[nodiscard]] QString address() const;
+[[nodiscard]] QString name() const;
+[[nodiscard]] QString layout() const;
+[[nodiscard]] QString activeKeymap() const;
+[[nodiscard]] bool capsLock() const;
+[[nodiscard]] bool numLock() const;
+[[nodiscard]] bool main() const;
 
-    bool updateLastIpcObject(QJsonObject object);
+bool updateLastIpcObject(QJsonObject object);
 
 signals:
-    void lastIpcObjectChanged();
-    void addressChanged();
-    void nameChanged();
-    void layoutChanged();
-    void activeKeymapChanged();
-    void capsLockChanged();
-    void numLockChanged();
-    void mainChanged();
+void lastIpcObjectChanged();
+void addressChanged();
+void nameChanged();
+void layoutChanged();
+void activeKeymapChanged();
+void capsLockChanged();
+void numLockChanged();
+void mainChanged();
 
 private:
-    QJsonObject m_lastIpcObject;
+QJsonObject m_lastIpcObject;
 };
 
 class HyprDevices : public QObject {
-    Q_OBJECT
-    QML_ELEMENT
-    QML_UNCREATABLE("HyprDevices instances can only be retrieved from a HyprExtras")
+Q_OBJECT
+QML_ELEMENT
+        QML_UNCREATABLE("HyprDevices instances can only be retrieved from a HyprExtras")
 
-    Q_PROPERTY(
-        QQmlListProperty<ZShell::internal::hypr::HyprKeyboard> keyboards READ keyboards NOTIFY keyboardsChanged)
+Q_PROPERTY(
+	QQmlListProperty<ZShell::internal::hypr::HyprKeyboard> keyboards READ keyboards NOTIFY keyboardsChanged)
 
 public:
-    explicit HyprDevices(QObject* parent = nullptr);
+explicit HyprDevices(QObject* parent = nullptr);
 
-    [[nodiscard]] QQmlListProperty<HyprKeyboard> keyboards();
+[[nodiscard]] QQmlListProperty<HyprKeyboard> keyboards();
 
-    bool updateLastIpcObject(QJsonObject object);
+bool updateLastIpcObject(QJsonObject object);
 
 signals:
-    void keyboardsChanged();
+void keyboardsChanged();
 
 private:
-    QList<HyprKeyboard*> m_keyboards;
+QList<HyprKeyboard*> m_keyboards;
 };
 
 } // namespace ZShell::internal::hypr

Plugins/ZShell/Internal/lidwatcher.cpp

@@ -6,7 +6,7 @@
 #include <QtDBus/qdbusreply.h>
 #include <qloggingcategory.h>
 
-Q_LOGGING_CATEGORY(lcLidWatcher, "caelestia.internal.logindmanager", QtInfoMsg)
+Q_LOGGING_CATEGORY(lcLidWatcher, "ZShell.internal.logindmanager", QtInfoMsg)
 
 namespace ZShell::internal {
 
@@ -14,27 +14,27 @@ LidWatcher::LidWatcher(QObject* parent) : QObject(parent) {
 	auto bus = QDBusConnection::systemBus();
 	if (!bus.isConnected()) {
 		qCWarning(lcLidWatcher)
-			<< "Failed to connect to system bus:" << bus.lastError().message();
+		        << "Failed to connect to system bus:" << bus.lastError().message();
 		return;
 	}
 
 	bool ok = bus.connect("org.freedesktop.login1",
-						  "/org/freedesktop/login1",
-						  "org.freedesktop.login1.Manager",
-						  "PrepareForSleep",
-						  this,
-						  SLOT(handlePrepareForSleep(bool)));
+	                      "/org/freedesktop/login1",
+	                      "org.freedesktop.login1.Manager",
+	                      "PrepareForSleep",
+	                      this,
+	                      SLOT(handlePrepareForSleep(bool)));
 
 	if (!ok) {
 		qCWarning(lcLidWatcher)
-			<< "Failed to connect to PrepareForSleep signal:"
-			<< bus.lastError().message();
+		        << "Failed to connect to PrepareForSleep signal:"
+		        << bus.lastError().message();
 	}
 
 	QDBusInterface login1("org.freedesktop.login1",
-						  "/org/freedesktop/login1",
-						  "org.freedesktop.login1.Manager",
-						  bus);
+	                      "/org/freedesktop/login1",
+	                      "org.freedesktop.login1.Manager",
+	                      bus);
 	const QDBusReply<QDBusObjectPath> reply = login1.call("GetSession", "auto");
 	if (!reply.isValid()) {
 		qCWarning(lcLidWatcher) << "Failed to get session path";
@@ -43,27 +43,27 @@ LidWatcher::LidWatcher(QObject* parent) : QObject(parent) {
 	const auto sessionPath = reply.value().path();
 
 	ok = bus.connect("org.freedesktop.login1",
-					 sessionPath,
-					 "org.freedesktop.login1.Session",
-					 "Lock",
-					 this,
-					 SLOT(handleLockRequested()));
+	                 sessionPath,
+	                 "org.freedesktop.login1.Session",
+	                 "Lock",
+	                 this,
+	                 SLOT(handleLockRequested()));
 
 	if (!ok) {
 		qCWarning(lcLidWatcher)
-			<< "Failed to connect to Lock signal:" << bus.lastError().message();
+		        << "Failed to connect to Lock signal:" << bus.lastError().message();
 	}
 
 	ok = bus.connect("org.freedesktop.login1",
-					 sessionPath,
-					 "org.freedesktop.login1.Session",
-					 "Unlock",
-					 this,
-					 SLOT(handleUnlockRequested()));
+	                 sessionPath,
+	                 "org.freedesktop.login1.Session",
+	                 "Unlock",
+	                 this,
+	                 SLOT(handleUnlockRequested()));
 
 	if (!ok) {
 		qCWarning(lcLidWatcher) << "Failed to connect to Unlock signal:"
-								<< bus.lastError().message();
+		                        << bus.lastError().message();
 	}
 }
 

Plugins/ZShell/Internal/lidwatcher.hpp

@@ -6,22 +6,22 @@
 namespace ZShell::internal {
 
 class LidWatcher : public QObject {
-	Q_OBJECT
-	QML_ELEMENT
+Q_OBJECT
+QML_ELEMENT
 
-	public:
-	explicit LidWatcher(QObject* parent = nullptr);
+public:
+explicit LidWatcher(QObject* parent = nullptr);
 
-	signals:
-	void aboutToSleep();
-	void resumed();
-	void lockRequested();
-	void unlockRequested();
+signals:
+void aboutToSleep();
+void resumed();
+void lockRequested();
+void unlockRequested();
 
-	private slots:
-	void handlePrepareForSleep(bool sleep);
-	void handleLockRequested();
-	void handleUnlockRequested();
+private slots:
+void handlePrepareForSleep(bool sleep);
+void handleLockRequested();
+void handleUnlockRequested();
 };
 
 } // namespace ZShell::internal

Plugins/ZShell/Internal/sparklineitem.cpp

@@ -4,7 +4,7 @@
 #include <qpainterpath.h>
 #include <qpen.h>
 
-namespace caelestia::internal {
+namespace ZShell::internal {
 
 SparklineItem::SparklineItem(QQuickItem* parent)
 	: QQuickPaintedItem(parent) {
@@ -212,4 +212,4 @@ void SparklineItem::setLineWidth(qreal width) {
 	update();
 }
 
-} // namespace caelestia::internal
+} // namespace ZShell::internal

Plugins/ZShell/Internal/sparklineitem.hpp

@@ -7,7 +7,7 @@
 
 #include "circularbuffer.hpp"
 
-namespace caelestia::internal {
+namespace ZShell::internal {
 
 class SparklineItem : public QQuickPaintedItem {
 Q_OBJECT
@@ -87,4 +87,4 @@ int m_historyLength = 30;
 qreal m_lineWidth = 2.0;
 };
 
-} // namespace caelestia::internal
+} // namespace ZShell::internal

Plugins/ZShell/Models/filesystemmodel.hpp

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <cstdint>
 #include <qabstractitemmodel.h>
 #include <qdir.h>
 #include <qfilesystemwatcher.h>
@@ -13,136 +14,136 @@
 namespace ZShell::models {
 
 class FileSystemEntry : public QObject {
-    Q_OBJECT
-    QML_ELEMENT
-    QML_UNCREATABLE("FileSystemEntry instances can only be retrieved from a FileSystemModel")
+Q_OBJECT
+QML_ELEMENT
+        QML_UNCREATABLE("FileSystemEntry instances can only be retrieved from a FileSystemModel")
 
-    Q_PROPERTY(QString path READ path CONSTANT)
-    Q_PROPERTY(QString relativePath READ relativePath NOTIFY relativePathChanged)
-    Q_PROPERTY(QString name READ name CONSTANT)
-    Q_PROPERTY(QString baseName READ baseName CONSTANT)
-    Q_PROPERTY(QString parentDir READ parentDir CONSTANT)
-    Q_PROPERTY(QString suffix READ suffix CONSTANT)
-    Q_PROPERTY(qint64 size READ size CONSTANT)
-    Q_PROPERTY(bool isDir READ isDir CONSTANT)
-    Q_PROPERTY(bool isImage READ isImage CONSTANT)
-    Q_PROPERTY(QString mimeType READ mimeType CONSTANT)
+Q_PROPERTY(QString path READ path CONSTANT)
+Q_PROPERTY(QString relativePath READ relativePath NOTIFY relativePathChanged)
+Q_PROPERTY(QString name READ name CONSTANT)
+Q_PROPERTY(QString baseName READ baseName CONSTANT)
+Q_PROPERTY(QString parentDir READ parentDir CONSTANT)
+Q_PROPERTY(QString suffix READ suffix CONSTANT)
+Q_PROPERTY(qint64 size READ size CONSTANT)
+Q_PROPERTY(bool isDir READ isDir CONSTANT)
+Q_PROPERTY(bool isImage READ isImage CONSTANT)
+Q_PROPERTY(QString mimeType READ mimeType CONSTANT)
 
 public:
-    explicit FileSystemEntry(const QString& path, const QString& relativePath, QObject* parent = nullptr);
+explicit FileSystemEntry(const QString& path, const QString& relativePath, QObject* parent = nullptr);
 
-    [[nodiscard]] QString path() const;
-    [[nodiscard]] QString relativePath() const;
-    [[nodiscard]] QString name() const;
-    [[nodiscard]] QString baseName() const;
-    [[nodiscard]] QString parentDir() const;
-    [[nodiscard]] QString suffix() const;
-    [[nodiscard]] qint64 size() const;
-    [[nodiscard]] bool isDir() const;
-    [[nodiscard]] bool isImage() const;
-    [[nodiscard]] QString mimeType() const;
+[[nodiscard]] QString path() const;
+[[nodiscard]] QString relativePath() const;
+[[nodiscard]] QString name() const;
+[[nodiscard]] QString baseName() const;
+[[nodiscard]] QString parentDir() const;
+[[nodiscard]] QString suffix() const;
+[[nodiscard]] qint64 size() const;
+[[nodiscard]] bool isDir() const;
+[[nodiscard]] bool isImage() const;
+[[nodiscard]] QString mimeType() const;
 
-    void updateRelativePath(const QDir& dir);
+void updateRelativePath(const QDir& dir);
 
 signals:
-    void relativePathChanged();
+void relativePathChanged();
 
 private:
-    const QFileInfo m_fileInfo;
+const QFileInfo m_fileInfo;
 
-    const QString m_path;
-    QString m_relativePath;
+const QString m_path;
+QString m_relativePath;
 
-    mutable bool m_isImage;
-    mutable bool m_isImageInitialised;
+mutable bool m_isImage;
+mutable bool m_isImageInitialised;
 
-    mutable QString m_mimeType;
-    mutable bool m_mimeTypeInitialised;
+mutable QString m_mimeType;
+mutable bool m_mimeTypeInitialised;
 };
 
 class FileSystemModel : public QAbstractListModel {
-    Q_OBJECT
-    QML_ELEMENT
+Q_OBJECT
+QML_ELEMENT
 
-    Q_PROPERTY(QString path READ path WRITE setPath NOTIFY pathChanged)
-    Q_PROPERTY(bool recursive READ recursive WRITE setRecursive NOTIFY recursiveChanged)
-    Q_PROPERTY(bool watchChanges READ watchChanges WRITE setWatchChanges NOTIFY watchChangesChanged)
-    Q_PROPERTY(bool showHidden READ showHidden WRITE setShowHidden NOTIFY showHiddenChanged)
-    Q_PROPERTY(bool sortReverse READ sortReverse WRITE setSortReverse NOTIFY sortReverseChanged)
-    Q_PROPERTY(Filter filter READ filter WRITE setFilter NOTIFY filterChanged)
-    Q_PROPERTY(QStringList nameFilters READ nameFilters WRITE setNameFilters NOTIFY nameFiltersChanged)
+Q_PROPERTY(QString path READ path WRITE setPath NOTIFY pathChanged)
+Q_PROPERTY(bool recursive READ recursive WRITE setRecursive NOTIFY recursiveChanged)
+Q_PROPERTY(bool watchChanges READ watchChanges WRITE setWatchChanges NOTIFY watchChangesChanged)
+Q_PROPERTY(bool showHidden READ showHidden WRITE setShowHidden NOTIFY showHiddenChanged)
+Q_PROPERTY(bool sortReverse READ sortReverse WRITE setSortReverse NOTIFY sortReverseChanged)
+Q_PROPERTY(Filter filter READ filter WRITE setFilter NOTIFY filterChanged)
+Q_PROPERTY(QStringList nameFilters READ nameFilters WRITE setNameFilters NOTIFY nameFiltersChanged)
 
-    Q_PROPERTY(QQmlListProperty<ZShell::models::FileSystemEntry> entries READ entries NOTIFY entriesChanged)
+Q_PROPERTY(QQmlListProperty<ZShell::models::FileSystemEntry> entries READ entries NOTIFY entriesChanged)
 
 public:
-    enum Filter {
-        NoFilter,
-        Images,
-        Files,
-        Dirs
-    };
-    Q_ENUM(Filter)
+enum Filter {
+	NoFilter,
+	Images,
+	Files,
+	Dirs
+};
+Q_ENUM(Filter)
 
-    explicit FileSystemModel(QObject* parent = nullptr);
+explicit FileSystemModel(QObject* parent = nullptr);
 
-    int rowCount(const QModelIndex& parent = QModelIndex()) const override;
-    QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override;
-    QHash<int, QByteArray> roleNames() const override;
+[[nodiscard]] int rowCount(const QModelIndex& parent = QModelIndex()) const override;
+[[nodiscard]] QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override;
+[[nodiscard]] QHash<int, QByteArray> roleNames() const override;
 
-    [[nodiscard]] QString path() const;
-    void setPath(const QString& path);
+[[nodiscard]] QString path() const;
+void setPath(const QString& path);
 
-    [[nodiscard]] bool recursive() const;
-    void setRecursive(bool recursive);
+[[nodiscard]] bool recursive() const;
+void setRecursive(bool recursive);
 
-    [[nodiscard]] bool watchChanges() const;
-    void setWatchChanges(bool watchChanges);
+[[nodiscard]] bool watchChanges() const;
+void setWatchChanges(bool watchChanges);
 
-    [[nodiscard]] bool showHidden() const;
-    void setShowHidden(bool showHidden);
+[[nodiscard]] bool showHidden() const;
+void setShowHidden(bool showHidden);
 
-    [[nodiscard]] bool sortReverse() const;
-    void setSortReverse(bool sortReverse);
+[[nodiscard]] bool sortReverse() const;
+void setSortReverse(bool sortReverse);
 
-    [[nodiscard]] Filter filter() const;
-    void setFilter(Filter filter);
+[[nodiscard]] Filter filter() const;
+void setFilter(Filter filter);
 
-    [[nodiscard]] QStringList nameFilters() const;
-    void setNameFilters(const QStringList& nameFilters);
+[[nodiscard]] QStringList nameFilters() const;
+void setNameFilters(const QStringList& nameFilters);
 
-    [[nodiscard]] QQmlListProperty<FileSystemEntry> entries();
+[[nodiscard]] QQmlListProperty<FileSystemEntry> entries();
 
 signals:
-    void pathChanged();
-    void recursiveChanged();
-    void watchChangesChanged();
-    void showHiddenChanged();
-    void sortReverseChanged();
-    void filterChanged();
-    void nameFiltersChanged();
-    void entriesChanged();
+void pathChanged();
+void recursiveChanged();
+void watchChangesChanged();
+void showHiddenChanged();
+void sortReverseChanged();
+void filterChanged();
+void nameFiltersChanged();
+void entriesChanged();
 
 private:
-    QDir m_dir;
-    QFileSystemWatcher m_watcher;
-    QList<FileSystemEntry*> m_entries;
-    QHash<QString, QFuture<QPair<QSet<QString>, QSet<QString>>>> m_futures;
+QDir m_dir;
+QFileSystemWatcher m_watcher;
+QList<FileSystemEntry*> m_entries;
+QHash<QString, QFuture<QPair<QSet<QString>, QSet<QString> > > > m_futures;
 
-    QString m_path;
-    bool m_recursive;
-    bool m_watchChanges;
-    bool m_showHidden;
-    bool m_sortReverse;
-    Filter m_filter;
-    QStringList m_nameFilters;
+QString m_path;
+bool m_recursive;
+bool m_watchChanges;
+bool m_showHidden;
+bool m_sortReverse;
+Filter m_filter;
+QStringList m_nameFilters;
 
-    void watchDirIfRecursive(const QString& path);
-    void update();
-    void updateWatcher();
-    void updateEntries();
-    void updateEntriesForDir(const QString& dir);
-    void applyChanges(const QSet<QString>& removedPaths, const QSet<QString>& addedPaths);
-    [[nodiscard]] bool compareEntries(const FileSystemEntry* a, const FileSystemEntry* b) const;
+void watchDirIfRecursive(const QString& path);
+void update();
+void updateWatcher();
+void updateEntries();
+void updateEntriesForDir(const QString& dir);
+void applyChanges(const QSet<QString>& removedPaths, const QSet<QString>& addedPaths);
+[[nodiscard]] bool compareEntries(const FileSystemEntry* a, const FileSystemEntry* b) const;
 };
 
 } // namespace ZShell::models

Plugins/ZShell/Services/audiocollector.hpp

@@ -59,7 +59,7 @@ quint32 readChunk(double* out, quint32 count = 0);
 
 private:
 explicit AudioCollector(QObject* parent = nullptr);
-~AudioCollector();
+~AudioCollector() override;
 
 std::jthread m_thread;
 std::vector<float> m_buffer1;

Plugins/ZShell/Services/audioprovider.hpp

@@ -11,11 +11,10 @@ Q_OBJECT
 
 public:
 explicit AudioProcessor(QObject* parent = nullptr);
-~AudioProcessor();
+~AudioProcessor() override;
 
 void init();
 
-public slots:
 void start();
 void stop();
 
@@ -31,7 +30,7 @@ Q_OBJECT
 
 public:
 explicit AudioProvider(QObject* parent = nullptr);
-~AudioProvider();
+~AudioProvider() override;
 
 protected:
 AudioProcessor* m_processor;

Plugins/ZShell/Services/beattracker.hpp

@@ -11,7 +11,7 @@ Q_OBJECT
 
 public:
 explicit BeatProcessor(QObject* parent = nullptr);
-~BeatProcessor();
+~BeatProcessor() override;
 
 signals:
 void beat(smpl_t bpm);

Plugins/ZShell/Services/cavaprovider.hpp

@@ -11,7 +11,7 @@ Q_OBJECT
 
 public:
 explicit CavaProcessor(QObject* parent = nullptr);
-~CavaProcessor();
+~CavaProcessor() override;
 
 void setBars(int bars);
 

Plugins/ZShell/Services/desktopmodel.hpp

@@ -4,6 +4,7 @@
 #include <QList>
 #include <QString>
 #include <QQmlEngine>
+#include <cstdint>
 
 namespace ZShell::services {
 
@@ -30,9 +31,9 @@ enum DesktopRoles {
 
 explicit DesktopModel(QObject *parent = nullptr);
 
-int rowCount(const QModelIndex &parent = QModelIndex()) const override;
-QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
-QHash<int, QByteArray> roleNames() const override;
+[[nodiscard]] int rowCount(const QModelIndex &parent = QModelIndex()) const override;
+[[nodiscard]] QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
+[[nodiscard]] QHash<int, QByteArray> roleNames() const override;
 
 Q_INVOKABLE void loadDirectory(const QString &path);
 Q_INVOKABLE void moveIcon(int index, int newX, int newY);
@@ -43,4 +44,4 @@ QList<DesktopItem> m_items;
 void saveCurrentLayout();
 };
 
-} // namespace ZShell::services
+} // namespace ZShell::Services

Plugins/ZShell/Services/desktopstatemanager.hpp

@@ -18,7 +18,7 @@ Q_INVOKABLE void saveLayout(const QVariantMap& layout);
 Q_INVOKABLE QVariantMap getLayout();
 
 private:
-QString getConfigFilePath() const;
+[[nodiscard]] QString getConfigFilePath() const;
 };
 
 } // namespace ZShell::services

Plugins/ZShell/Services/hyprsunsetmanager.cpp

@@ -104,10 +104,12 @@ void HyprsunsetManager::toggle() {
 }
 
 void HyprsunsetManager::start() {
-	if (m_enabled)
+	if (m_enabled && m_initialized)
 		return;
 
+	m_initialized = true;
 	m_enabled = true;
+
 	emit enabledChanged();
 
 	m_process.setProgram("hyprctl");
@@ -116,10 +118,12 @@ void HyprsunsetManager::start() {
 }
 
 void HyprsunsetManager::end() {
-	if (!m_enabled)
+	if (!m_enabled && m_initialized)
 		return;
 
+	m_initialized = true;
 	m_enabled = false;
+
 	emit enabledChanged();
 
 	m_process.setProgram("hyprctl");

Plugins/ZShell/Services/hyprsunsetmanager.hpp

@@ -22,12 +22,13 @@ Q_PROPERTY(bool manualToggle READ manualToggle WRITE setManualToggle NOTIFY manu
 public:
 explicit HyprsunsetManager(QObject* parent = nullptr);
 
-int startTime() const;
-int endTime() const;
-bool enabled() const;
-int temp() const;
-bool activeAuto() const;
-bool manualToggle() const;
+[[nodiscard]] int startTime() const;
+[[nodiscard]] int endTime() const;
+[[nodiscard]] bool enabled() const;
+[[nodiscard]] int temp() const;
+[[nodiscard]] bool activeAuto() const;
+[[nodiscard]] bool manualToggle() const;
+
 Q_INVOKABLE void toggle();
 Q_INVOKABLE void apply();
 
@@ -48,10 +49,11 @@ void manualToggleChanged();
 private:
 int m_startTime;
 int m_endTime;
-bool m_enabled;
+bool m_enabled = false;
 bool m_manualToggle = false;
 bool m_activeAuto;
-bool m_startAllowed;
+bool m_startAllowed = false;
+bool m_initialized = false;
 QTimer m_startCooldown;
 int m_temp;
 QProcess m_process;

Plugins/ZShell/appdb.hpp

@@ -9,98 +9,98 @@
 namespace ZShell {
 
 class AppEntry : public QObject {
-    Q_OBJECT
-    QML_ELEMENT
-    QML_UNCREATABLE("AppEntry instances can only be retrieved from an AppDb")
+Q_OBJECT
+QML_ELEMENT
+        QML_UNCREATABLE("AppEntry instances can only be retrieved from an AppDb")
 
-    // The actual DesktopEntry, but we don't have access to the type so it's a QObject
-    Q_PROPERTY(QObject* entry READ entry CONSTANT)
+// The actual DesktopEntry, but we don't have access to the type so it's a QObject
+Q_PROPERTY(QObject* entry READ entry CONSTANT)
 
-    Q_PROPERTY(quint32 frequency READ frequency NOTIFY frequencyChanged)
-    Q_PROPERTY(QString id READ id CONSTANT)
-    Q_PROPERTY(QString name READ name NOTIFY nameChanged)
-    Q_PROPERTY(QString comment READ comment NOTIFY commentChanged)
-    Q_PROPERTY(QString execString READ execString NOTIFY execStringChanged)
-    Q_PROPERTY(QString startupClass READ startupClass NOTIFY startupClassChanged)
-    Q_PROPERTY(QString genericName READ genericName NOTIFY genericNameChanged)
-    Q_PROPERTY(QString categories READ categories NOTIFY categoriesChanged)
-    Q_PROPERTY(QString keywords READ keywords NOTIFY keywordsChanged)
+Q_PROPERTY(quint32 frequency READ frequency NOTIFY frequencyChanged)
+Q_PROPERTY(QString id READ id CONSTANT)
+Q_PROPERTY(QString name READ name NOTIFY nameChanged)
+Q_PROPERTY(QString comment READ comment NOTIFY commentChanged)
+Q_PROPERTY(QString execString READ execString NOTIFY execStringChanged)
+Q_PROPERTY(QString startupClass READ startupClass NOTIFY startupClassChanged)
+Q_PROPERTY(QString genericName READ genericName NOTIFY genericNameChanged)
+Q_PROPERTY(QString categories READ categories NOTIFY categoriesChanged)
+Q_PROPERTY(QString keywords READ keywords NOTIFY keywordsChanged)
 
 public:
-    explicit AppEntry(QObject* entry, quint32 frequency, QObject* parent = nullptr);
+explicit AppEntry(QObject* entry, quint32 frequency, QObject* parent = nullptr);
 
-    [[nodiscard]] QObject* entry() const;
+[[nodiscard]] QObject* entry() const;
 
-    [[nodiscard]] quint32 frequency() const;
-    void setFrequency(quint32 frequency);
-    void incrementFrequency();
+[[nodiscard]] quint32 frequency() const;
+void setFrequency(quint32 frequency);
+void incrementFrequency();
 
-    [[nodiscard]] QString id() const;
-    [[nodiscard]] QString name() const;
-    [[nodiscard]] QString comment() const;
-    [[nodiscard]] QString execString() const;
-    [[nodiscard]] QString startupClass() const;
-    [[nodiscard]] QString genericName() const;
-    [[nodiscard]] QString categories() const;
-    [[nodiscard]] QString keywords() const;
+[[nodiscard]] QString id() const;
+[[nodiscard]] QString name() const;
+[[nodiscard]] QString comment() const;
+[[nodiscard]] QString execString() const;
+[[nodiscard]] QString startupClass() const;
+[[nodiscard]] QString genericName() const;
+[[nodiscard]] QString categories() const;
+[[nodiscard]] QString keywords() const;
 
 signals:
-    void frequencyChanged();
-    void nameChanged();
-    void commentChanged();
-    void execStringChanged();
-    void startupClassChanged();
-    void genericNameChanged();
-    void categoriesChanged();
-    void keywordsChanged();
+void frequencyChanged();
+void nameChanged();
+void commentChanged();
+void execStringChanged();
+void startupClassChanged();
+void genericNameChanged();
+void categoriesChanged();
+void keywordsChanged();
 
 private:
-    QObject* m_entry;
-    quint32 m_frequency;
+QObject* m_entry;
+quint32 m_frequency;
 };
 
 class AppDb : public QObject {
-    Q_OBJECT
-    QML_ELEMENT
+Q_OBJECT
+QML_ELEMENT
 
-    Q_PROPERTY(QString uuid READ uuid CONSTANT)
-    Q_PROPERTY(QString path READ path WRITE setPath NOTIFY pathChanged REQUIRED)
-    Q_PROPERTY(QObjectList entries READ entries WRITE setEntries NOTIFY entriesChanged REQUIRED)
-    Q_PROPERTY(QQmlListProperty<ZShell::AppEntry> apps READ apps NOTIFY appsChanged)
+Q_PROPERTY(QString uuid READ uuid CONSTANT)
+Q_PROPERTY(QString path READ path WRITE setPath NOTIFY pathChanged REQUIRED)
+Q_PROPERTY(QObjectList entries READ entries WRITE setEntries NOTIFY entriesChanged REQUIRED)
+Q_PROPERTY(QQmlListProperty<ZShell::AppEntry> apps READ apps NOTIFY appsChanged)
 
 public:
-    explicit AppDb(QObject* parent = nullptr);
+explicit AppDb(QObject* parent = nullptr);
 
-    [[nodiscard]] QString uuid() const;
+[[nodiscard]] QString uuid() const;
 
-    [[nodiscard]] QString path() const;
-    void setPath(const QString& path);
+[[nodiscard]] QString path() const;
+void setPath(const QString& path);
 
-    [[nodiscard]] QObjectList entries() const;
-    void setEntries(const QObjectList& entries);
+[[nodiscard]] QObjectList entries() const;
+void setEntries(const QObjectList& entries);
 
-    [[nodiscard]] QQmlListProperty<AppEntry> apps();
+[[nodiscard]] QQmlListProperty<AppEntry> apps();
 
-    Q_INVOKABLE void incrementFrequency(const QString& id);
+Q_INVOKABLE void incrementFrequency(const QString& id);
 
 signals:
-    void pathChanged();
-    void entriesChanged();
-    void appsChanged();
+void pathChanged();
+void entriesChanged();
+void appsChanged();
 
 private:
-    QTimer* m_timer;
+QTimer* m_timer;
 
-    const QString m_uuid;
-    QString m_path;
-    QObjectList m_entries;
-    QHash<QString, AppEntry*> m_apps;
-    mutable QList<AppEntry*> m_sortedApps;
+const QString m_uuid;
+QString m_path;
+QObjectList m_entries;
+QHash<QString, AppEntry*> m_apps;
+mutable QList<AppEntry*> m_sortedApps;
 
-    QList<AppEntry*>& getSortedApps() const;
-    quint32 getFrequency(const QString& id) const;
-    void updateAppFrequencies();
-    void updateApps();
+QList<AppEntry*>& getSortedApps() const;
+quint32 getFrequency(const QString& id) const;
+void updateAppFrequencies();
+void updateApps();
 };
 
 } // namespace ZShell

Plugins/ZShell/imageanalyser.hpp

@@ -9,53 +9,53 @@
 namespace ZShell {
 
 class ImageAnalyser : public QObject {
-    Q_OBJECT
-    QML_ELEMENT
+Q_OBJECT
+QML_ELEMENT
 
-    Q_PROPERTY(QString source READ source WRITE setSource NOTIFY sourceChanged)
-    Q_PROPERTY(QQuickItem* sourceItem READ sourceItem WRITE setSourceItem NOTIFY sourceItemChanged)
-    Q_PROPERTY(int rescaleSize READ rescaleSize WRITE setRescaleSize NOTIFY rescaleSizeChanged)
-    Q_PROPERTY(QColor dominantColour READ dominantColour NOTIFY dominantColourChanged)
-    Q_PROPERTY(qreal luminance READ luminance NOTIFY luminanceChanged)
+Q_PROPERTY(QString source READ source WRITE setSource NOTIFY sourceChanged)
+Q_PROPERTY(QQuickItem* sourceItem READ sourceItem WRITE setSourceItem NOTIFY sourceItemChanged)
+Q_PROPERTY(int rescaleSize READ rescaleSize WRITE setRescaleSize NOTIFY rescaleSizeChanged)
+Q_PROPERTY(QColor dominantColour READ dominantColour NOTIFY dominantColourChanged)
+Q_PROPERTY(qreal luminance READ luminance NOTIFY luminanceChanged)
 
 public:
-    explicit ImageAnalyser(QObject* parent = nullptr);
+explicit ImageAnalyser(QObject* parent = nullptr);
 
-    [[nodiscard]] QString source() const;
-    void setSource(const QString& source);
+[[nodiscard]] QString source() const;
+void setSource(const QString& source);
 
-    [[nodiscard]] QQuickItem* sourceItem() const;
-    void setSourceItem(QQuickItem* sourceItem);
+[[nodiscard]] QQuickItem* sourceItem() const;
+void setSourceItem(QQuickItem* sourceItem);
 
-    [[nodiscard]] int rescaleSize() const;
-    void setRescaleSize(int rescaleSize);
+[[nodiscard]] int rescaleSize() const;
+void setRescaleSize(int rescaleSize);
 
-    [[nodiscard]] QColor dominantColour() const;
-    [[nodiscard]] qreal luminance() const;
+[[nodiscard]] QColor dominantColour() const;
+[[nodiscard]] qreal luminance() const;
 
-    Q_INVOKABLE void requestUpdate();
+Q_INVOKABLE void requestUpdate();
 
 signals:
-    void sourceChanged();
-    void sourceItemChanged();
-    void rescaleSizeChanged();
-    void dominantColourChanged();
-    void luminanceChanged();
+void sourceChanged();
+void sourceItemChanged();
+void rescaleSizeChanged();
+void dominantColourChanged();
+void luminanceChanged();
 
 private:
-    using AnalyseResult = QPair<QColor, qreal>;
+using AnalyseResult = QPair<QColor, qreal>;
 
-    QFutureWatcher<AnalyseResult>* const m_futureWatcher;
+QFutureWatcher<AnalyseResult>* const m_futureWatcher;
 
-    QString m_source;
-    QQuickItem* m_sourceItem;
-    int m_rescaleSize;
+QString m_source;
+QQuickItem* m_sourceItem;
+int m_rescaleSize;
 
-    QColor m_dominantColour;
-    qreal m_luminance;
+QColor m_dominantColour;
+qreal m_luminance;
 
-    void update();
-    static void analyse(QPromise<AnalyseResult>& promise, const QImage& image, int rescaleSize);
+void update();
+static void analyse(QPromise<AnalyseResult>& promise, const QImage& image, int rescaleSize);
 };
 
 } // namespace ZShell

Plugins/ZShell/qalculator.hpp

@@ -13,7 +13,7 @@ QML_SINGLETON
 public:
 explicit Qalculator(QObject* parent = nullptr);
 
-Q_INVOKABLE QString eval(const QString& expr, bool printExpr = true) const;
+Q_INVOKABLE [[nodiscard]] QString eval(const QString& expr, bool printExpr = true) const;
 };
 
 } // namespace ZShell

Plugins/ZShell/toaster.hpp

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <cstdint>
 #include <qobject.h>
 #include <qqmlintegration.h>
 #include <qqmllist.h>
@@ -20,7 +21,7 @@ Q_PROPERTY(int timeout READ timeout CONSTANT)
 Q_PROPERTY(Type type READ type CONSTANT)
 
 public:
-enum class Type {
+enum class Type: std::uint8_t {
 	Info = 0,
 	Success,
 	Warning,

Plugins/ZShell/writefile.hpp

@@ -29,9 +29,9 @@ Q_INVOKABLE void cacheImage(const QUrl& source, const QString& cacheDir, QJSValu
 Q_INVOKABLE void cacheImage(const QUrl& source, const QString& cacheDir, QJSValue onSaved, QJSValue onFailed);
 // clang-format on
 
-Q_INVOKABLE bool copyFile(const QUrl& source, const QUrl& target, bool overwrite = true) const;
-Q_INVOKABLE bool deleteFile(const QUrl& path) const;
-Q_INVOKABLE QString toLocalFile(const QUrl& url) const;
+Q_INVOKABLE [[nodiscard]] bool copyFile(const QUrl& source, const QUrl& target, bool overwrite = true) const;
+Q_INVOKABLE [[nodiscard]] bool deleteFile(const QUrl& path) const;
+Q_INVOKABLE [[nodiscard]] QString toLocalFile(const QUrl& url) const;
 
 private:
 bool loadSourceImage(const QUrl& source, QImage& image) const;