fix(strokecanvasitem): use qreal instead of float to suppress -Wdouble-promotion

### Goal

Idea is to reduce the annoyances and research which clang-tidy rules make sense and actually have benefits in our project.

Also considering immediately resolving most if not all tidy warnings.

### Current Changes

- `.clang-tidy` has changes to follow the guidelines we have been following silently. Some rules were different from how we program.
    - Note that naming is completely removed and won't be checked. In a future PR (where we go over the code to fix linting issues), we can reintroduce them and make sure they fit our codebase consistently.
- tidy rules are not considered errors anymore (stopped compile).
- CI/CD addition to build check and clang-tidy check. Tried to get clang-tidy check to show when failed, but that causes complications in its checks; so now it is simply silent when failing.
- Dockerfile that creates an arch container as cache for the CI/CD, prevents redownload of dependencies each run. Instead, it runs weekly (or optionally a different interval).

### Current complications

- To push the docker container build, it would require this webserver to allow larger filesize pushes (need ~2GB). Current workaround is arguably better where docker build is pushed to runner server.
- Figuring out which clang-tidy rules make sense.

Reviewed-on: #130
Co-authored-by: AramJonghu <aramjonghu@tutamail.com>
Co-committed-by: AramJonghu <aramjonghu@tutamail.com>

.clang-tidy

@@ -2,29 +2,20 @@
 Checks: >
     -*,
     bugprone-*,
+    -bugprone-easily-swappable-parameters,
+    -bugprone-narrowing-conversions,
+    -bugprone-implicit-widening-of-multiplication-result,
     clang-analyzer-*,
-    modernize-*,
+    cppcoreguidelines-init-variables,
-    -modernize-use-trailing-return-type,
+    misc-no-recursion,
-    performance-*,
+    concurrency-mt-unsafe,
-    readability-braces-around-statements,
     readability-else-after-return,
-    readability-identifier-naming,
+    readability-make-member-function-const,
     readability-redundant-*,
     readability-simplify-*,
-CheckOptions:
+    modernize-use-override,
-    readability-identifier-naming.ClassCase: CamelCase
+    modernize-use-nullptr,
-    readability-identifier-naming.EnumCase: CamelCase
+    modernize-deprecated-headers,
-    readability-identifier-naming.FunctionCase: camelBack
-    readability-identifier-naming.MemberCase: camelBack
-    readability-identifier-naming.MemberPrefix: m_
-    readability-identifier-naming.MethodCase: camelBack
-    readability-identifier-naming.NamespaceCase: CamelCase
-    readability-identifier-naming.ParameterCase: camelBack
-    readability-identifier-naming.PrivateMemberPrefix: m_
-    readability-identifier-naming.StaticConstantCase: UPPER_CASE
-    readability-identifier-naming.StaticConstantPrefix: k
-    readability-identifier-naming.VariableCase: camelBack
-WarningsAsErrors: "*"
 HeaderFilterRegex: ".*"
 FormatStyle: file
 

.gitea/workflows/ci-image.yml

@@ -0,0 +1,30 @@
+name: Rebuild CI Image
+
+on:
+    schedule:
+        - cron: '0 6 * * 1'
+    workflow_dispatch:
+
+jobs:
+    build:
+        runs-on: alpine
+        container:
+            image: node:26-alpine
+        env:
+            IMAGE: git.aramjonghu.nl/aramjonghu/zshell-ci:latest
+
+        steps:
+            - name: Checkout
+              uses: actions/checkout@v4
+
+            - name: Install Docker CLI
+              run: apk add --no-cache docker-cli
+
+            - name: Login to registry
+              run: echo "${{ secrets.REGISTRY_TOKEN }}" | docker login git.aramjonghu.nl --username aramjonghu --password-stdin
+
+            - name: Build image
+              run: docker build -t "$IMAGE" -f ci/Dockerfile .
+
+            - name: Push image
+              run: docker push "$IMAGE"

.gitea/workflows/cpp.yml

@@ -0,0 +1,29 @@
+name: C++
+
+on:
+    pull_request:
+
+jobs:
+    build:
+        runs-on: alpine
+        container:
+            image: git.aramjonghu.nl/aramjonghu/zshell-ci:latest
+
+        steps:
+            - name: Checkout
+              uses: actions/checkout@v4
+              with:
+                  fetch-depth: 0
+
+            - name: Configure
+              run: cmake -B build -G Ninja -DENABLE_MODULES=plugin -DCMAKE_BUILD_TYPE=Release
+
+            - name: Build
+              run: ninja -C build
+
+            - name: clang-tidy
+              continue-on-error: true
+              run: |
+                  set -o pipefail
+                  run-clang-tidy -p build -j $(nproc) -header-filter="Plugins/.*" 2>&1 | \
+                    grep -v 'Suppressed\|non-user\|non-system\|unknown argument.*mno-direct'

CMakeLists.txt

@@ -1,6 +1,35 @@
 cmake_minimum_required(VERSION 3.19)
 
-project(ZShell)
+if(NOT DEFINED VERSION)
+	execute_process(
+		COMMAND git describe --tags --abbrev=0
+		WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
+		OUTPUT_VARIABLE GIT_LAST_TAG
+		OUTPUT_STRIP_TRAILING_WHITESPACE
+		ERROR_QUIET
+	)
+
+	if (GIT_LAST_TAG)
+		string(REGEX REPLACE "^v" "" GIT_LAST_TAG "${GIT_LAST_TAG}")
+
+		string(REPLACE "." ";" VERSION_LIST "${GIT_LAST_TAG}")
+		list(GET VERSION_LIST 0 VERSION_MAJOR)
+		list(GET VERSION_LIST 1 VERSION_MINOR)
+
+		execute_process(
+			COMMAND git rev-list v${VERSION_MAJOR}.${VERSION_MINOR}.0..HEAD --count
+			WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
+			OUTPUT_VARIABLE VERSION_PATCH
+			OUTPUT_STRIP_TRAILING_WHITESPACE
+			ERROR_QUIET
+		)
+	endif()
+endif()
+
+set(VERSION "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}")
+
+project(ZShell VERSION ${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH})
+message(STATUS "ZShell version: ${VERSION}")
 
 set(CMAKE_CXX_STANDARD 20)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)

Plugins/ZShell/CMakeLists.txt

@@ -66,6 +66,8 @@ qml_module(ZShell
 		PkgConfig::Qalculate
 )
 
+target_compile_definitions(ZShell PRIVATE ZSHELL_VERSION="${VERSION}")
+
 add_subdirectory(Models)
 add_subdirectory(Internal)
 add_subdirectory(Services)

Plugins/ZShell/Components/lazylistview.cpp

@@ -1,6 +1,7 @@
 #include "lazylistview.hpp"
 
 #include <algorithm>
+#include <cmath>
 #include <qqmlcontext.h>
 #include <qtimer.h>
 
@@ -13,11 +14,7 @@ constexpr int ASYNC_BATCH_DESTROY = 4;
 
 namespace ZShell::components {
 
-// --- LazyListViewAttached ---
+LazyListViewAttached::LazyListViewAttached(QObject* parent) : QObject(parent) {}
-
-LazyListViewAttached::LazyListViewAttached(QObject* parent)
-	: QObject(parent) {
-}
 
 qreal LazyListViewAttached::preferredHeight() const {
 	return m_preferredHeight;
@@ -85,10 +82,7 @@ void LazyListViewAttached::setTrackViewport(bool track) {
 	emit trackViewportChanged();
 }
 
-// --- LazyListView ---
+LazyListView::LazyListView(QQuickItem* parent) : QQuickItem(parent) {
-
-LazyListView::LazyListView(QQuickItem* parent)
-	: QQuickItem(parent) {
 	setFlag(ItemHasContents, false);
 }
 
@@ -103,8 +97,6 @@ LazyListView::~LazyListView() {
 		destroyDelegate(entry);
 }
 
-// --- Model & Delegate ---
-
 QAbstractItemModel* LazyListView::model() const {
 	return m_model;
 }
@@ -138,8 +130,6 @@ void LazyListView::setDelegate(QQmlComponent* delegate) {
 	emit delegateChanged();
 }
 
-// --- Layout ---
-
 qreal LazyListView::spacing() const {
 	return m_spacing;
 }
@@ -172,8 +162,6 @@ void LazyListView::setContentY(qreal contentY) {
 	polish();
 }
 
-// --- Viewport ---
-
 QRectF LazyListView::viewport() const {
 	return m_viewport;
 }
@@ -211,8 +199,6 @@ void LazyListView::setCacheBuffer(qreal buffer) {
 	polish();
 }
 
-// --- Sizing ---
-
 qreal LazyListView::estimatedHeight() const {
 	return m_estimatedHeight;
 }
@@ -258,7 +244,8 @@ qreal LazyListView::delegateHeight(QQuickItem* item) {
 	if (!item)
 		return 0;
 
-	auto* attached = qobject_cast<LazyListViewAttached*>(qmlAttachedPropertiesObject<LazyListView>(item, false));
+	auto* attached = qobject_cast<LazyListViewAttached*>(
+		qmlAttachedPropertiesObject<LazyListView>(item, false));
 	if (attached && attached->preferredHeight() >= 0)
 		return attached->preferredHeight();
 
@@ -269,7 +256,8 @@ qreal LazyListView::delegateVisibleHeight(QQuickItem* item) {
 	if (!item)
 		return 0;
 
-	auto* attached = qobject_cast<LazyListViewAttached*>(qmlAttachedPropertiesObject<LazyListView>(item, false));
+	auto* attached = qobject_cast<LazyListViewAttached*>(
+		qmlAttachedPropertiesObject<LazyListView>(item, false));
 	if (attached) {
 		if (attached->visibleHeight() >= 0)
 			return attached->visibleHeight();
@@ -283,12 +271,11 @@ qreal LazyListView::delegateVisibleHeight(QQuickItem* item) {
 bool LazyListView::isDelegateReady(QQuickItem* item) {
 	if (!item)
 		return false;
-	auto* att = qobject_cast<LazyListViewAttached*>(qmlAttachedPropertiesObject<LazyListView>(item, false));
+	auto* att = qobject_cast<LazyListViewAttached*>(
+		qmlAttachedPropertiesObject<LazyListView>(item, false));
 	return !att || att->ready();
 }
 
-// --- Animation Durations ---
-
 int LazyListView::removeDuration() const {
 	return m_removeDuration;
 }
@@ -311,21 +298,18 @@ void LazyListView::setReadyDelay(int delay) {
 	emit readyDelayChanged();
 }
 
-// --- State ---
-
 int LazyListView::count() const {
 	return m_model ? m_model->rowCount() : 0;
 }
 
-// --- QQuickItem Overrides ---
-
 void LazyListView::componentComplete() {
 	QQuickItem::componentComplete();
 	m_componentComplete = true;
 	resetContent();
 }
 
-void LazyListView::geometryChange(const QRectF& newGeometry, const QRectF& oldGeometry) {
+void LazyListView::geometryChange(const QRectF& newGeometry,
+								  const QRectF& oldGeometry) {
 	QQuickItem::geometryChange(newGeometry, oldGeometry);
 
 	if (!m_componentComplete)
@@ -348,9 +332,16 @@ void LazyListView::updatePolish() {
 	// Flush pending inserts — make items visible and clear the adding flag
 	// so enter animations begin. When readyDelay > 0 the entire insert is
 	// deferred so delegates have time to lay out before appearing.
-	for (auto& entry : m_delegates) {
+
-		if (!entry.pendingInsert || !entry.item)
+	// Collect pending indices first — avoids scanning the entire hash each frame
-			continue;
+	QList<int> pendingIndices;
+	for (auto it = m_delegates.constBegin(); it != m_delegates.constEnd(); ++it) {
+		if (it->pendingInsert && it->item)
+			pendingIndices.append(it.key());
+	}
+
+	for (int pendingIdx : pendingIndices) {
+		auto& entry = m_delegates[pendingIdx];
 
 		if (m_readyDelay > 0) {
 			if (!entry.readyDelayStarted) {
@@ -362,7 +353,8 @@ void LazyListView::updatePolish() {
 						return;
 					const int idx = indexIt.value();
 					auto it = m_delegates.find(idx);
-						if (it == m_delegates.end() || it->item != item || !it->pendingInsert)
+					if (it == m_delegates.end() || it->item != item ||
+						!it->pendingInsert)
 						return;
 
 					it->pendingInsert = false;
@@ -372,13 +364,16 @@ void LazyListView::updatePolish() {
 					if (idx >= 0 && idx < static_cast<int>(m_layout.size())) {
 						qreal visualY = 0;
 						bool hasVisItem = false;
-							for (int i = 0; i < static_cast<int>(m_layout.size()); ++i) {
+						for (int i = 0; i < static_cast<int>(m_layout.size());
-								qreal h;
+							 ++i) {
+							qreal h = NAN;
 							auto dit = m_delegates.find(i);
 							if (dit != m_delegates.end() && dit->item)
 								h = delegateVisibleHeight(dit->item);
 							else
-									h = m_layout[i].heightKnown ? m_layout[i].height : effectiveEstimatedHeight();
+								h = m_layout[i].heightKnown
+										? m_layout[i].height
+										: effectiveEstimatedHeight();
 							if (h > 0) {
 								if (hasVisItem)
 									visualY += m_spacing;
@@ -393,8 +388,8 @@ void LazyListView::updatePolish() {
 					}
 
 					item->setVisible(true);
-						auto* att =
+					auto* att = qobject_cast<LazyListViewAttached*>(
-							qobject_cast<LazyListViewAttached*>(qmlAttachedPropertiesObject<LazyListView>(item, false));
+						qmlAttachedPropertiesObject<LazyListView>(item, false));
 					if (att) {
 						att->setAdding(false);
 						att->setReady(true);
@@ -402,7 +397,8 @@ void LazyListView::updatePolish() {
 
 					// Animate from visual position to layout position
 					if (idx >= 0 && idx < static_cast<int>(m_layout.size()))
-							item->setProperty("y", m_layout[idx].targetY - m_contentY);
+						item->setProperty("y",
+										  m_layout[idx].targetY - m_contentY);
 
 					polish();
 				});
@@ -412,7 +408,8 @@ void LazyListView::updatePolish() {
 
 		entry.pendingInsert = false;
 		entry.item->setVisible(true);
-		auto* att = qobject_cast<LazyListViewAttached*>(qmlAttachedPropertiesObject<LazyListView>(entry.item, false));
+		auto* att = qobject_cast<LazyListViewAttached*>(
+			qmlAttachedPropertiesObject<LazyListView>(entry.item, false));
 		if (att) {
 			att->setAdding(false);
 			att->setReady(true);
@@ -429,12 +426,13 @@ void LazyListView::updatePolish() {
 		record.isNew = false;
 
 	// Position delegates — QML Behavior on y handles the animation
+	const int layoutSize = static_cast<int>(m_layout.size());
 	for (auto& entry : m_delegates) {
 		if (!entry.item || entry.pendingRemoval || entry.pendingInsert)
 			continue;
 
 		const int idx = entry.modelIndex;
-		if (idx < 0 || idx >= static_cast<int>(m_layout.size()))
+		if (idx < 0 || idx >= layoutSize)
 			continue;
 
 		if (m_layout[idx].heightKnown && qFuzzyIsNull(m_layout[idx].height))
@@ -454,7 +452,8 @@ void LazyListView::relayout() {
 	qreal y = 0;
 	bool hasLayoutItem = false;
 	for (auto& record : m_layout) {
-		const qreal layoutH = record.heightKnown ? record.height : effectiveEstimatedHeight();
+		const qreal layoutH = record.heightKnown ? record.height
+												 : effectiveEstimatedHeight();
 		if (layoutH > 0) {
 			if (hasLayoutItem)
 				y += m_spacing;
@@ -476,12 +475,13 @@ void LazyListView::relayout() {
 	qreal visY = 0;
 	bool hasVisItem = false;
 	for (int i = 0; i < static_cast<int>(m_layout.size()); ++i) {
-		qreal h;
+		qreal h = NAN;
 		auto dit = m_delegates.find(i);
 		if (dit != m_delegates.end() && dit->item)
 			h = delegateVisibleHeight(dit->item);
 		else
-			h = m_layout[i].heightKnown ? m_layout[i].height : effectiveEstimatedHeight();
+			h = m_layout[i].heightKnown ? m_layout[i].height
+										: effectiveEstimatedHeight();
 		if (h > 0) {
 			if (hasVisItem)
 				visY += m_spacing;
@@ -559,7 +559,9 @@ std::pair<int, int> LazyListView::computeVisibleRange() const {
 	while (lo <= hi) {
 		const int mid = lo + (hi - lo) / 2;
 		const auto& record = m_layout[mid];
-		const qreal itemBottom = record.targetY + (record.heightKnown ? record.height : effectiveEstimatedHeight());
+		const qreal itemBottom =
+			record.targetY +
+			(record.heightKnown ? record.height : effectiveEstimatedHeight());
 
 		if (itemBottom >= vpTop) {
 			first = mid;
@@ -612,9 +614,12 @@ void LazyListView::syncDelegates() {
 	}
 
 	// Batch destroy
-	const int destroyBudget = m_asynchronous ? ASYNC_BATCH_DESTROY : static_cast<int>(toRemove.size());
+	const int destroyBudget = m_asynchronous
+								  ? ASYNC_BATCH_DESTROY
+								  : static_cast<int>(toRemove.size());
 	QVector<DelegateEntry> removedEntries;
-	removedEntries.reserve(std::min(destroyBudget, static_cast<int>(toRemove.size())));
+	removedEntries.reserve(
+		std::min(destroyBudget, static_cast<int>(toRemove.size())));
 	int destroyed = 0;
 	for (int idx : toRemove) {
 		if (destroyed >= destroyBudget)
@@ -638,7 +643,8 @@ void LazyListView::syncDelegates() {
 	}
 
 	// Batch create
-	const int createBudget = m_asynchronous ? ASYNC_BATCH_CREATE : static_cast<int>(toCreate.size());
+	const int createBudget = m_asynchronous ? ASYNC_BATCH_CREATE
+											: static_cast<int>(toCreate.size());
 	int created = 0;
 	for (int i : toCreate) {
 		if (created >= createBudget)
@@ -658,7 +664,8 @@ void LazyListView::syncDelegates() {
 
 	// Pending inserts need to become visible on the next frame, and
 	// async mode may have remaining create/destroy work.
-	if (created > 0 || (m_asynchronous && (destroyed < static_cast<int>(toRemove.size()) ||
+	if (created > 0 ||
+		(m_asynchronous && (destroyed < static_cast<int>(toRemove.size()) ||
 							created < static_cast<int>(toCreate.size()))))
 		polish();
 }
@@ -704,8 +711,10 @@ LazyListView::DelegateEntry LazyListView::createDelegate(int modelIndex) {
 	initialProps.insert(QStringLiteral("index"), modelIndex);
 
 	if (!hasModelData) {
-		const auto role = roleNames.isEmpty() ? Qt::DisplayRole : roleNames.constBegin().key();
+		const auto role = roleNames.isEmpty() ? Qt::DisplayRole
-		initialProps.insert(QStringLiteral("modelData"), m_model->data(index, role));
+											  : roleNames.constBegin().key();
+		initialProps.insert(QStringLiteral("modelData"),
+							m_model->data(index, role));
 	}
 
 	m_delegate->setInitialProperties(entry.item, initialProps);
@@ -715,9 +724,10 @@ LazyListView::DelegateEntry LazyListView::createDelegate(int modelIndex) {
 
 	// Only set adding = true for genuinely new model items (not viewport entries).
 	// Cleared on the next frame in updatePolish when the item becomes visible.
-	if (modelIndex < static_cast<int>(m_layout.size()) && m_layout[modelIndex].isNew) {
+	if (modelIndex < static_cast<int>(m_layout.size()) &&
-		auto* addingAttached =
+		m_layout[modelIndex].isNew) {
-			qobject_cast<LazyListViewAttached*>(qmlAttachedPropertiesObject<LazyListView>(entry.item, true));
+		auto* addingAttached = qobject_cast<LazyListViewAttached*>(
+			qmlAttachedPropertiesObject<LazyListView>(entry.item, true));
 		if (addingAttached)
 			addingAttached->setAdding(true);
 	}
@@ -740,7 +750,8 @@ LazyListView::DelegateEntry LazyListView::createDelegate(int modelIndex) {
 		if (delegateIt == m_delegates.end() || delegateIt->item != item)
 			return;
 		const qreal h = delegateHeight(item);
-				       if (idx < static_cast<int>(m_layout.size()) && !qFuzzyCompare(m_layout[idx].height + 1.0, h + 1.0)) {
+		if (idx < static_cast<int>(m_layout.size()) &&
+			!qFuzzyCompare(m_layout[idx].height + 1.0, h + 1.0)) {
 			const qreal oldH = m_layout[idx].height;
 			const bool wasKnown = m_layout[idx].heightKnown;
 			m_layout[idx].height = h;
@@ -752,9 +763,11 @@ LazyListView::DelegateEntry LazyListView::createDelegate(int modelIndex) {
 			// If this tracked item is above the viewport, emit a
 			// compensation delta so the consumer can adjust scroll.
 			if (wasKnown) {
-						       auto* att = qobject_cast<LazyListViewAttached*>(qmlAttachedPropertiesObject<LazyListView>(item, false));
+				auto* att = qobject_cast<LazyListViewAttached*>(
+					qmlAttachedPropertiesObject<LazyListView>(item, false));
 				if (att && att->trackViewport()) {
-							       const qreal vpTop = m_useCustomViewport ? m_viewport.y() : m_contentY;
+					const qreal vpTop = m_useCustomViewport ? m_viewport.y()
+															: m_contentY;
 					if (m_layout[idx].targetY < vpTop)
 						emit viewportAdjustNeeded(h - oldH);
 				}
@@ -772,36 +785,52 @@ LazyListView::DelegateEntry LazyListView::createDelegate(int modelIndex) {
 	};
 
 	// Watch implicitHeight as fallback
-	connect(entry.item, &QQuickItem::implicitHeightChanged, this, onHeightChanged);
+	connect(entry.item,
+			&QQuickItem::implicitHeightChanged,
+			this,
+			onHeightChanged);
 
 	// Watch attached properties if the delegate uses them
-	auto* attached = qobject_cast<LazyListViewAttached*>(qmlAttachedPropertiesObject<LazyListView>(entry.item, false));
+	auto* attached = qobject_cast<LazyListViewAttached*>(
+		qmlAttachedPropertiesObject<LazyListView>(entry.item, false));
 	if (attached) {
-		connect(attached, &LazyListViewAttached::preferredHeightChanged, this, onHeightChanged);
+		connect(attached,
-		connect(attached, &LazyListViewAttached::visibleHeightChanged, this, [this] {
+				&LazyListViewAttached::preferredHeightChanged,
-				polish();
+				this,
-			});
+				onHeightChanged);
-		connect(attached, &LazyListViewAttached::readyChanged, this, [this, item = entry.item] {
+		connect(attached,
+				&LazyListViewAttached::visibleHeightChanged,
+				this,
+				[this] { polish(); });
+		connect(attached,
+				&LazyListViewAttached::readyChanged,
+				this,
+				[this, item = entry.item] {
 					auto indexIt = m_itemToIndex.find(item);
 					if (indexIt == m_itemToIndex.end())
 						return;
 					const int idx = indexIt.value();
 					if (idx >= static_cast<int>(m_layout.size()))
 						return;
-				auto* att = qobject_cast<LazyListViewAttached*>(qmlAttachedPropertiesObject<LazyListView>(item, false));
+					auto* att = qobject_cast<LazyListViewAttached*>(
+						qmlAttachedPropertiesObject<LazyListView>(item, false));
 					if (!att || !att->ready())
 						return;
 
 					const qreal h = delegateHeight(item);
-				const qreal oldLayoutH = m_layout[idx].heightKnown ? m_layout[idx].height : effectiveEstimatedHeight();
+					const qreal oldLayoutH = m_layout[idx].heightKnown
+												 ? m_layout[idx].height
+												 : effectiveEstimatedHeight();
 					if (m_layout[idx].heightKnown)
 						untrackHeight(m_layout[idx].height);
 					m_layout[idx].height = h;
 					m_layout[idx].heightKnown = true;
 					trackHeight(h);
 
-				if (att->trackViewport() && !qFuzzyCompare(h + 1.0, oldLayoutH + 1.0)) {
+					if (att->trackViewport() &&
-					const qreal vpTop = m_useCustomViewport ? m_viewport.y() : m_contentY;
+						!qFuzzyCompare(h + 1.0, oldLayoutH + 1.0)) {
+						const qreal vpTop = m_useCustomViewport ? m_viewport.y()
+																: m_contentY;
 						if (m_layout[idx].targetY < vpTop)
 							emit viewportAdjustNeeded(h - oldLayoutH);
 					}
@@ -832,7 +861,8 @@ void LazyListView::updateDelegateData(DelegateEntry& entry) {
 
 	for (auto it = roleNames.constBegin(); it != roleNames.constEnd(); ++it) {
 		const auto name = QString::fromUtf8(it.value());
-		entry.item->setProperty(name.toUtf8().constData(), m_model->data(index, it.key()));
+		entry.item->setProperty(name.toUtf8().constData(),
+								m_model->data(index, it.key()));
 		if (name == QStringLiteral("modelData"))
 			hasModelData = true;
 	}
@@ -840,7 +870,8 @@ void LazyListView::updateDelegateData(DelegateEntry& entry) {
 	entry.item->setProperty("index", entry.modelIndex);
 
 	if (!hasModelData) {
-		const auto role = roleNames.isEmpty() ? Qt::DisplayRole : roleNames.constBegin().key();
+		const auto role = roleNames.isEmpty() ? Qt::DisplayRole
+											  : roleNames.constBegin().key();
 		entry.item->setProperty("modelData", m_model->data(index, role));
 	}
 }
@@ -852,19 +883,41 @@ void LazyListView::connectModel() {
 		return;
 
 	m_modelConnections = {
-		connect(m_model, &QAbstractItemModel::rowsInserted, this, &LazyListView::onRowsInserted),
+		connect(m_model,
-		connect(m_model, &QAbstractItemModel::rowsAboutToBeRemoved, this, &LazyListView::onRowsAboutToBeRemoved),
+				&QAbstractItemModel::rowsInserted,
-		connect(m_model, &QAbstractItemModel::rowsRemoved, this, &LazyListView::onRowsRemoved),
+				this,
-		connect(m_model, &QAbstractItemModel::rowsMoved, this, &LazyListView::onRowsMoved),
+				&LazyListView::onRowsInserted),
-		connect(m_model, &QAbstractItemModel::dataChanged, this, &LazyListView::onDataChanged),
+		connect(m_model,
-		connect(m_model, &QAbstractItemModel::modelReset, this, &LazyListView::onModelReset),
+				&QAbstractItemModel::rowsAboutToBeRemoved,
-		connect(m_model, &QAbstractItemModel::layoutChanged, this,
+				this,
+				&LazyListView::onRowsAboutToBeRemoved),
+		connect(m_model,
+				&QAbstractItemModel::rowsRemoved,
+				this,
+				&LazyListView::onRowsRemoved),
+		connect(m_model,
+				&QAbstractItemModel::rowsMoved,
+				this,
+				&LazyListView::onRowsMoved),
+		connect(m_model,
+				&QAbstractItemModel::dataChanged,
+				this,
+				&LazyListView::onDataChanged),
+		connect(m_model,
+				&QAbstractItemModel::modelReset,
+				this,
+				&LazyListView::onModelReset),
+		connect(m_model,
+				&QAbstractItemModel::layoutChanged,
+				this,
 				[this] {
 					for (auto& entry : m_delegates)
 						updateDelegateData(entry);
 					polish();
 				}),
-		connect(m_model, &QObject::destroyed, this,
+		connect(m_model,
+				&QObject::destroyed,
+				this,
 				[this] {
 					m_model = nullptr;
 					resetContent();
@@ -909,7 +962,9 @@ void LazyListView::resetContent() {
 	polish();
 }
 
-void LazyListView::onRowsInserted(const QModelIndex& parent, int first, int last) {
+void LazyListView::onRowsInserted(const QModelIndex& parent,
+								  int first,
+								  int last) {
 	if (parent.isValid())
 		return;
 
@@ -935,7 +990,9 @@ void LazyListView::onRowsInserted(const QModelIndex& parent, int first, int last
 	polish();
 }
 
-void LazyListView::onRowsAboutToBeRemoved(const QModelIndex& parent, int first, int last) {
+void LazyListView::onRowsAboutToBeRemoved(const QModelIndex& parent,
+										  int first,
+										  int last) {
 	if (parent.isValid())
 		return;
 
@@ -955,15 +1012,17 @@ void LazyListView::onRowsAboutToBeRemoved(const QModelIndex& parent, int first,
 		}
 
 		if (m_removeDuration > 0 && entry.item) {
-			auto* attached =
+			auto* attached = qobject_cast<LazyListViewAttached*>(
-				qobject_cast<LazyListViewAttached*>(qmlAttachedPropertiesObject<LazyListView>(entry.item, false));
+				qmlAttachedPropertiesObject<LazyListView>(entry.item, false));
 			if (attached)
 				attached->setRemoving(true);
 
 			// Schedule destruction after the remove animation duration
 			auto* item = entry.item;
 			QTimer::singleShot(m_removeDuration, this, [this, item] {
-					for (auto it = m_dyingDelegates.begin(); it != m_dyingDelegates.end(); ++it) {
+				for (auto it = m_dyingDelegates.begin();
+					 it != m_dyingDelegates.end();
+					 ++it) {
 					if (it->item == item) {
 						destroyDelegate(*it);
 						m_dyingDelegates.erase(it);
@@ -978,7 +1037,9 @@ void LazyListView::onRowsAboutToBeRemoved(const QModelIndex& parent, int first,
 	}
 }
 
-void LazyListView::onRowsRemoved(const QModelIndex& parent, int first, int last) {
+void LazyListView::onRowsRemoved(const QModelIndex& parent,
+								 int first,
+								 int last) {
 	if (parent.isValid())
 		return;
 
@@ -1011,7 +1072,11 @@ void LazyListView::onRowsRemoved(const QModelIndex& parent, int first, int last)
 	polish();
 }
 
-void LazyListView::onRowsMoved(const QModelIndex& parent, int start, int end, const QModelIndex& destination, int row) {
+void LazyListView::onRowsMoved(const QModelIndex& parent,
+							   int start,
+							   int end,
+							   const QModelIndex& destination,
+							   int row) {
 	if (parent.isValid() || destination.isValid())
 		return;
 
@@ -1055,7 +1120,9 @@ void LazyListView::onRowsMoved(const QModelIndex& parent, int start, int end, co
 	polish();
 }
 
-void LazyListView::onDataChanged(const QModelIndex& topLeft, const QModelIndex& bottomRight, const QList<int>& roles) {
+void LazyListView::onDataChanged(const QModelIndex& topLeft,
+								 const QModelIndex& bottomRight,
+								 const QList<int>& roles) {
 	Q_UNUSED(roles)
 
 	if (topLeft.parent().isValid())
@@ -1079,15 +1146,18 @@ void LazyListView::onModelReset() {
 	// Check if the model data actually changed
 	if (newRows == oldRows) {
 		const auto roleNames = m_model->roleNames();
-		const auto role = roleNames.isEmpty() ? Qt::DisplayRole : roleNames.constBegin().key();
+		const auto role = roleNames.isEmpty() ? Qt::DisplayRole
+											  : roleNames.constBegin().key();
 		bool changed = false;
 
-		for (auto it = m_delegates.constBegin(); it != m_delegates.constEnd(); ++it) {
+		for (auto it = m_delegates.constBegin(); it != m_delegates.constEnd();
+			 ++it) {
 			if (!it->item || it.key() >= newRows) {
 				changed = true;
 				break;
 			}
-			const auto newData = m_model->data(m_model->index(it.key(), 0), role);
+			const auto newData =
+				m_model->data(m_model->index(it.key(), 0), role);
 			const auto oldData = it->item->property("modelData");
 			if (newData != oldData) {
 				changed = true;

Plugins/ZShell/Internal/strokecanvasitem.cpp

@@ -6,7 +6,8 @@
 
 namespace ZShell::internal {
 
-StrokeCanvasItem::StrokeCanvasItem(QQuickItem *parent) : QCanvasPainterItem(parent) {
+StrokeCanvasItem::StrokeCanvasItem(QQuickItem* parent)
+	: QCanvasPainterItem(parent) {
 	setFillColor(Qt::transparent);
 	setAlphaBlending(true);
 }
@@ -16,38 +17,34 @@ QCanvasPainterItemRenderer *StrokeCanvasItem::createItemRenderer() const {
 }
 
 static bool shouldAddPoint(
-	const QVector<QPointF> &points,
+	const QVector<QPointF>& points, const QPointF& p, qreal minDistance) {
-	const QPointF &p,
+	if (points.isEmpty()) return true;
-	qreal minDistance)
-{
-	if (points.isEmpty())
-		return true;
 
 	const QPointF delta = p - points.last();
 
-	return QPointF::dotProduct(delta, delta)
+	return QPointF::dotProduct(delta, delta) >= minDistance * minDistance;
-	       >= minDistance * minDistance;
 }
 
-static QCanvasPath buildStrokePath(const QVector<QPointF> &points, float width) {
+static QCanvasPath buildStrokePath(const QVector<QPointF>& points, qreal width) {
 	QCanvasPath path;
 
 	if (points.size() == 1) {
-		path.circle(points[0], width * 0.5f);
+		path.circle(points[0], width * 0.5);
 		return path;
 	}
 
-	auto catmullToBezier = [](
+	auto catmullToBezier = [](const QPointF& p0,
-		const QPointF &p0, const QPointF &p1,
+							  const QPointF& p1,
-		const QPointF &p2, const QPointF &p3,
+							  const QPointF& p2,
-		float tension,
+							  const QPointF& p3,
-		QPointF &cp1, QPointF &cp2)
+							  qreal tension,
-			       {
+							  QPointF& cp1,
-				       cp1 = p1 + (p2 - p0) * tension / 3.0f;
+							  QPointF& cp2) {
-				       cp2 = p2 - (p3 - p1) * tension / 3.0f;
+		cp1 = p1 + (p2 - p0) * tension / 3.0;
+		cp2 = p2 - (p3 - p1) * tension / 3.0;
 	};
 
-	const float tension = 0.5f;
+	const qreal tension = 0.5;
 	path.moveTo(points[0]);
 
 	for (int i = 0; i < points.size() - 1; ++i) {
@@ -65,8 +62,7 @@ static QCanvasPath buildStrokePath(const QVector<QPointF> &points, float width)
 }
 
 void StrokeCanvasItem::setPenColor(const QColor& color) {
-	if (m_penColor == color)
+	if (m_penColor == color) return;
-		return;
 
 	m_penColor = color;
 	update();
@@ -75,8 +71,7 @@ void StrokeCanvasItem::setPenColor(const QColor &color) {
 }
 
 void StrokeCanvasItem::setHoverVisible(bool visible) {
-	if (m_hoverVisible == visible)
+	if (m_hoverVisible == visible) return;
-		return;
 
 	m_hoverVisible = visible;
 	update();
@@ -85,8 +80,7 @@ void StrokeCanvasItem::setHoverVisible(bool visible) {
 }
 
 void StrokeCanvasItem::setHoverPoint(const QPointF& point) {
-	if (m_hoverPoint == point)
+	if (m_hoverPoint == point) return;
-		return;
 
 	m_hoverPoint = point;
 	update();
@@ -110,8 +104,7 @@ void StrokeCanvasItem::showHover(qreal x, qreal y) {
 }
 
 void StrokeCanvasItem::hideHover() {
-	if (!m_hoverVisible)
+	if (!m_hoverVisible) return;
-		return;
 
 	m_hoverVisible = false;
 	update();
@@ -120,8 +113,7 @@ void StrokeCanvasItem::hideHover() {
 }
 
 void StrokeCanvasItem::setPenWidth(float width) {
-	if (qFuzzyCompare(m_penWidth, width))
+	if (qFuzzyCompare(m_penWidth, width)) return;
-		return;
 
 	m_penWidth = width;
 	update();
@@ -143,8 +135,7 @@ void StrokeCanvasItem::beginStroke(qreal x, qreal y) {
 void StrokeCanvasItem::appendPoint(qreal x, qreal y) {
 	const QPointF incoming{x, y};
 
-	if (!shouldAddPoint(m_currentStroke.points, incoming, 2.0))
+	if (!shouldAddPoint(m_currentStroke.points, incoming, 2.0)) return;
-		return;
 
 	QPointF smoothed;
 	if (m_currentStroke.points.isEmpty()) {
@@ -159,7 +150,8 @@ void StrokeCanvasItem::appendPoint(qreal x, qreal y) {
 		constexpr qreal minAlpha = 0.1;
 		constexpr qreal maxAlpha = 0.3;
 
-		const qreal t = std::clamp((dist - minDist) / (maxDist - minDist), 0.0, 1.0);
+		const qreal t =
+			std::clamp((dist - minDist) / (maxDist - minDist), 0.0, 1.0);
 		const qreal alpha = minAlpha + t * (maxAlpha - minAlpha);
 
 		smoothed = last * (1.0 - alpha) + incoming * alpha;
@@ -171,11 +163,11 @@ void StrokeCanvasItem::appendPoint(qreal x, qreal y) {
 
 void StrokeCanvasItem::endStroke() {
 	m_isDrawing = false;
-	if (m_currentStroke.points.isEmpty())
+	if (m_currentStroke.points.isEmpty()) return;
-		return;
 
 	m_currentStroke.isSinglePoint = (m_currentStroke.points.size() == 1);
-	m_currentStroke.path = buildStrokePath(m_currentStroke.points, m_currentStroke.width);
+	m_currentStroke.path =
+		buildStrokePath(m_currentStroke.points, m_currentStroke.width);
 	m_currentStroke.groupId = m_nextGroupId++;
 	m_currentStroke.points.clear();
 	m_strokes.append(m_currentStroke);
@@ -190,4 +182,4 @@ void StrokeCanvasItem::clear() {
 	update();
 }
 
-};
+}; // namespace ZShell::internal

Plugins/ZShell/zutils.cpp

@@ -3,9 +3,11 @@
 #include <QtConcurrent/qtconcurrentrun.h>
 #include <QtQuick/qquickitemgrabresult.h>
 #include <QtQuick/qquickwindow.h>
+#include <qcontainerfwd.h>
 #include <qdir.h>
 #include <qfileinfo.h>
 #include <qfuturewatcher.h>
+#include <qjsprimitivevalue.h>
 #include <qloggingcategory.h>
 #include <qqmlengine.h>
 
@@ -142,4 +144,16 @@ qreal ZUtils::clamp(qreal value, qreal min, qreal max) {
 	return qBound(min, value, max);
 }
 
+#ifndef ZSHELL_VERSION
+#define ZSHELL_VERSION ""
+#endif
+
+QString ZUtils::version() const {
+	return QStringLiteral(ZSHELL_VERSION);
+}
+
+QString ZUtils::qtVersion() const {
+	return QStringLiteral(QT_VERSION_STR);
+}
+
 } // namespace ZShell

Plugins/ZShell/zutils.hpp

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <QtQuick/qquickitem.h>
+#include <qcontainerfwd.h>
 #include <qobject.h>
 #include <qqmlintegration.h>
 
@@ -26,6 +27,9 @@ Q_INVOKABLE static bool deleteFile(const QUrl& path);
 Q_INVOKABLE static QString toLocalFile(const QUrl& url);
 
 Q_INVOKABLE static qreal clamp(qreal value, qreal min, qreal max);
+
+[[nodiscard]] QString version() const;
+[[nodiscard]] QString qtVersion() const;
 };
 
 } // namespace ZShell

ci/Dockerfile

@@ -0,0 +1,43 @@
+FROM archlinux:latest
+
+RUN pacman -Syu --noconfirm
+
+# Build toolchain
+RUN pacman -S --noconfirm \
+    base-devel \
+    cmake \
+    ninja \
+    clang \
+    lld \
+    nodejs \
+    git
+
+# Qt6
+RUN pacman -S --noconfirm \
+    qt6-base \
+    qt6-declarative \
+    qt6-shadertools \
+    qt6-5compat \
+    qt6-canvaspainter
+
+# Project-specific dependencies
+RUN pacman -S --noconfirm \
+    libqalculate \
+    pipewire \
+    aubio \
+    cava \
+    lm_sensors \
+    glib2
+
+# AUR: libcava (provides development headers for cava)
+RUN pacman -S --needed --noconfirm sudo && \
+    useradd -m builder && \
+    echo "builder ALL=(ALL) NOPASSWD: ALL" >> /etc/sudoers && \
+    su builder -c " \
+        git clone https://aur.archlinux.org/libcava.git /tmp/libcava && \
+        cd /tmp/libcava && \
+        makepkg -si --noconfirm \
+    " && \
+    rm -rf /tmp/libcava && \
+    userdel -r builder && \
+    sed -i '/^builder/d' /etc/sudoers