zach/z-bar-qt
1
1
Fork 0
Code Issues 22 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

hotfix zshell-cli autocompletion failing #108

Merged
zach merged 5 commits from hotfix-zshell-autocompletion into main 2026-05-28 23:24:17 +02:00
Conversation 3 Commits 5 Files Changed 1
+9 -4
AramJonghu commented 2026-05-28 14:26:00 +02:00
Collaborator
Copy Link
Copy Source

Autocompletion is currently broken. This PR aims to resolve the issue.

Calling completion_init() only when _ZSHELL_CLI_COMPLETE env variable is set. Without completion_init(), even when autocomplete was installed, the shell would return Shell zsh not supported..

Autocompletion is currently broken. This PR aims to resolve the issue. Calling `completion_init()` only when `_ZSHELL_CLI_COMPLETE` env variable is set. Without `completion_init()`, even when autocomplete was installed, the shell would return `Shell zsh not supported.`.
AramJonghu added the bug label 2026-05-28 14:26:00 +02:00
AramJonghu self-assigned this 2026-05-28 14:26:00 +02:00
AramJonghu added 3 commits 2026-05-28 14:26:00 +02:00
attempt hotfix fda3712855
now a check if cli completion is installed 0ad28ac017
ctx is unused
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 13s
Details
Python / lint-format (pull_request) Successful in 19s
Details
Python / test (pull_request) Successful in 47s
Details
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m46s
Details
e9aa8268be
AramJonghu requested review from zach 2026-05-28 14:26:00 +02:00
zach added 1 commit 2026-05-28 16:55:43 +02:00
Merge branch 'main' into hotfix-zshell-autocompletion
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 11s
Details
Python / lint-format (pull_request) Successful in 18s
Details
Python / test (pull_request) Successful in 1m20s
Details
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m57s
Details
494653e029
zach requested changes 2026-05-28 17:04:13 +02:00
Dismissed
zach left a comment
Owner
Copy Link
Copy Source

Completions now work as intended.

However, running zshell-cli --install-autocomplete when autocompletion is already installed raises a click.exceptions.Exit:

zshell-cli: Shell completion already installed.
Traceback (most recent call last):
  File "/usr/bin/zshell-cli", line 8, in <module>
    sys.exit(main())
             ~~~~^^
  File "/usr/lib/python3.14/site-packages/zshell/__init__.py", line 51, in main
    _install_completion()
    ~~~~~~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.14/site-packages/zshell/__init__.py", line 35, in _install_completion
    raise typer.Exit()
click.exceptions.Exit

Maybe we should hide this since it isn't very informative and can cause confusion.

Completions now work as intended. However, running `zshell-cli --install-autocomplete` when autocompletion is already installed raises a `click.exceptions.Exit`: ``` zshell-cli: Shell completion already installed. Traceback (most recent call last): File "/usr/bin/zshell-cli", line 8, in <module> sys.exit(main()) ~~~~^^ File "/usr/lib/python3.14/site-packages/zshell/__init__.py", line 51, in main _install_completion() ~~~~~~~~~~~~~~~~~~~^^ File "/usr/lib/python3.14/site-packages/zshell/__init__.py", line 35, in _install_completion raise typer.Exit() click.exceptions.Exit ``` Maybe we should hide this since it isn't very informative and can cause confusion.
👍 1
AramJonghu added 1 commit 2026-05-28 22:43:29 +02:00
removed exception in favor of sys.exit() to exit silently with print
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 12s
Details
Python / lint-format (pull_request) Successful in 20s
Details
Python / test (pull_request) Successful in 44s
Details
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m46s
Details
52be099914
AramJonghu commented 2026-05-28 22:47:34 +02:00
Author
Collaborator
Copy Link
Copy Source

Resolved now. It returns a simple print.

zshell-cli --install-autocomplete
zshell-cli: Shell completion already installed.
Resolved now. It returns a simple print. ``` zshell-cli --install-autocomplete zshell-cli: Shell completion already installed. ```
AramJonghu requested review from zach 2026-05-28 22:47:44 +02:00
zach approved these changes 2026-05-28 23:24:13 +02:00
zach merged commit 428809fee8 into main 2026-05-28 23:24:17 +02:00
AramJonghu deleted branch hotfix-zshell-autocompletion 2026-05-28 23:26:37 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
zach
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
AramJonghu Inorishio zach
No Assignees AramJonghu
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zach/z-bar-qt#108
Delete Branch "hotfix-zshell-autocompletion"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?