CI: typecheck fixes include dependencies + arch Dockerfile build fix #148

Merged

zach merged 2 commits from fix/cli-typecheck into main 2026-08-15 18:03:54 +02:00

Conversation 1 Commits 2 Files Changed 3

+21 -8

AramJonghu commented 2026-08-14 19:44:24 +02:00

Collaborator

Copy Link

Copy Source

What & why

CI typecheck lacked the dependencies to do a proper basedpyright check. This resulted in reportMissingImports errors.

Changes also include optional dependency for pytest (for writing test as a dev).

PR also includes a minor fix to ci/Dockerfile. libcava failed to build. Now it works and tested succesfully.

Related issue

No response

Type

CI / build / tooling

Tested

• Build succeeds
• Existing tests pass
• Manually verified

Breaking changes?

To get dependencies updated (such as pytest), run:

source .venv/bin/activate
pip install -e '.[dev]'

Checklist

• CI passes (format, lint, typecheck)
• Clean commits
• No new warnings
• Docs updated if needed

### What & why CI typecheck lacked the dependencies to do a proper basedpyright check. This resulted in `reportMissingImports` errors. Changes also include optional dependency for pytest (for writing test as a dev). PR also includes a minor fix to `ci/Dockerfile`. libcava failed to build. Now it works and tested succesfully. ### Related issue _No response_ ### Type CI / build / tooling ### Tested - [x] Build succeeds - [x] Existing tests pass - [x] Manually verified ### Breaking changes? To get dependencies updated (such as pytest), run: ```sh source .venv/bin/activate pip install -e '.[dev]' ``` ### Checklist - [x] CI passes (format, lint, typecheck) - [x] Clean commits - [x] No new warnings - [ ] Docs updated if needed

AramJonghu self-assigned this 2026-08-14 19:44:24 +02:00

AramJonghu added 1 commit 2026-08-14 19:44:24 +02:00

ci: add relevant dependencies; resolves MissingImport a1a8a6e695

AramJonghu marked the pull request as ready for review 2026-08-14 19:52:18 +02:00

AramJonghu requested review from zach 2026-08-14 19:52:25 +02:00

AramJonghu added 1 commit 2026-08-14 20:00:34 +02:00

ci: libcava dev headers abf7382771

AramJonghu changed title from CI: typecheck fixes include dependencies to CI: typecheck fixes include dependencies + arch Dockerfile build fix 2026-08-14 20:07:41 +02:00

zach approved these changes 2026-08-15 18:03:51 +02:00

zach merged commit 5e97ea6867 into main 2026-08-15 18:03:54 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

zach

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

AramJonghu Inorishio zach

No Assignees AramJonghu

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zach/z-bar-qt#148