changed old appearance vars for the lockscreen + warning hunting for the polkit #154

Merged

zach merged 2 commits from fix/lockscreen-font into main 2026-08-31 00:14:06 +02:00

Conversation 2 Commits 2 Files Changed 4

+11 -11

Inorishio commented 2026-08-30 23:38:09 +02:00

Collaborator

Copy Link

Copy Source

What & why

Changed property names in lock to abide our newly changed properties.
Currently the set font aren't being used for the lockscreen.

Added fallback to warnings from the polkit that kept appearing in zshell's logs.

Related issue

No response

Type

Refactor / style

Tested

• Build succeeds
• Existing tests pass
• Manually verified

Breaking changes?

Should be nothing as there are just property changes and two fallbacks that got added.

Checklist

• CI passes (format, lint, typecheck)
• Clean commits
• No new warnings
• Docs updated if needed

### What & why Changed property names in lock to abide our newly changed properties. Currently the set font aren't being used for the lockscreen. Added fallback to warnings from the polkit that kept appearing in zshell's logs. ### Related issue _No response_ ### Type Refactor / style ### Tested - [x] Build succeeds - [x] Existing tests pass - [ ] Manually verified ### Breaking changes? Should be nothing as there are just property changes and two fallbacks that got added. ### Checklist - [x] CI passes (format, lint, typecheck) - [ ] Clean commits - [ ] No new warnings - [ ] Docs updated if needed

Inorishio added 1 commit 2026-08-30 23:38:09 +02:00

changed old appearance vars for the lockscreen + warning hunting for the polkit 9370284c6b

AramJonghu requested review from AramJonghu 2026-08-30 23:44:53 +02:00

AramJonghu requested review from zach 2026-08-30 23:44:54 +02:00

AramJonghu approved these changes 2026-08-30 23:48:02 +02:00

AramJonghu left a comment

Collaborator

Copy Link

Copy Source

For cleaner commit messages; look up conventional commits. Otherwise, seems fine to me.

For cleaner commit messages; look up [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). Otherwise, seems fine to me.

zach added 1 commit 2026-08-31 00:13:18 +02:00

Merge branch 'main' into fix/lockscreen-font 2f6847ce0e

zach approved these changes 2026-08-31 00:13:43 +02:00

zach merged commit 04869656aa into main 2026-08-31 00:14:06 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

AramJonghu

zach

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

AramJonghu Inorishio zach

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zach/z-bar-qt#154