zach/z-bar-qt
1
1
Fork 0
Code Issues 23 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

Lint/formatter workflows merged per language. Resolved errors and warnings for each workflow #90

Merged
zach merged 12 commits from 89-lint-format-fixes into main 2026-05-20 07:33:57 +02:00
Conversation 1 Commits 12 Files Changed 16
+408 -377
AramJonghu commented 2026-05-19 23:58:20 +02:00
Collaborator
Copy Link
Copy Source

Should all be resolved, but do check if logic has changed that might break something. Looks good on my end.

Should all be resolved, but do check if logic has changed that might break something. Looks good on my end.
AramJonghu added 2 commits 2026-05-19 23:58:20 +02:00
prettier and eslint ignore valid syntax for qml specific syntax. Clippy lint resolved in .rs. unused py files commented to be ignored by ruff dd49198cf7
adjusted workflows -> merge of lint/formatter per lang
Lint & Format (JS/TS) / lint-format (pull_request) Failing after 10s
Details
Lint & Format (Python) / lint-format (pull_request) Failing after 19s
Details
Lint & Format (Rust) / lint-format (pull_request) Failing after 33s
Details
902863e5ba
AramJonghu requested review from Inorishio 2026-05-19 23:58:20 +02:00
AramJonghu requested review from zach 2026-05-19 23:58:20 +02:00
AramJonghu added 1 commit 2026-05-20 00:02:18 +02:00
minor changes to workflows to prevent preemptive exits/failures
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 12s
Details
Lint & Format (Python) / lint-format (pull_request) Successful in 21s
Details
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m34s
Details
ca3a288eab
AramJonghu added 1 commit 2026-05-20 00:05:31 +02:00
eslint workflow now prints a succes or fail message eslint is run succesfully or if it ran but failed
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 12s
Details
Lint & Format (Python) / lint-format (pull_request) Successful in 18s
Details
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m46s
Details
794a26a3fe
AramJonghu added 1 commit 2026-05-20 00:06:35 +02:00
main.rs formatted
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 20s
Details
Lint & Format (Python) / lint-format (pull_request) Successful in 26s
Details
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m36s
Details
c9d6b95ca5
AramJonghu added 1 commit 2026-05-20 00:11:24 +02:00
added cargo to be cached to avoid recompiling every time. Also added echo messages for more info
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 13s
Details
Lint & Format (Python) / lint-format (pull_request) Successful in 19s
Details
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m35s
Details
a3d0ee18cb
AramJonghu added 1 commit 2026-05-20 00:19:53 +02:00
changed github specific caching to forgejo's solution
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 13s
Details
Lint & Format (Python) / lint-format (pull_request) Successful in 18s
Details
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m31s
Details
d3f6765819
AramJonghu added 1 commit 2026-05-20 00:26:54 +02:00
wrong cache url
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 12s
Details
Lint & Format (Python) / lint-format (pull_request) Successful in 17s
Details
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m30s
Details
a14ebe2016
AramJonghu added 1 commit 2026-05-20 00:47:04 +02:00
minor updates to rust workflow
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 12s
Details
Lint & Format (Python) / lint-format (pull_request) Successful in 19s
Details
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m33s
Details
7276ee28dc
AramJonghu commented 2026-05-20 00:53:00 +02:00
Author
Collaborator
Copy Link
Copy Source

Tried to implement caching for the rust workflow, sadly not successful as it re-compiles on each run. It is what it is for now.

Tried to implement caching for the rust workflow, sadly not successful as it re-compiles on each run. It is what it is for now.
AramJonghu added 1 commit 2026-05-20 00:59:45 +02:00
use of newest node version available + attempt cache v3 vs v4
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 25s
Details
Lint & Format (Python) / lint-format (pull_request) Successful in 25s
Details
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m31s
Details
01b54ec5e1
AramJonghu added 1 commit 2026-05-20 01:03:55 +02:00
removal of cache (for now)
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 12s
Details
Lint & Format (Python) / lint-format (pull_request) Successful in 20s
Details
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m33s
Details
c88aef2164
zach added 1 commit 2026-05-20 05:24:04 +02:00
reintroduce cargo caching
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 12s
Details
Lint & Format (Python) / lint-format (pull_request) Successful in 20s
Details
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m39s
Details
053efb4aaf
zach merged commit 68662120ba into main 2026-05-20 07:33:57 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Inorishio
zach
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AramJonghu Inorishio zach
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zach/z-bar-qt#90