AramJonghu
AramJonghu pushed to tidy-warning-fixes at zach/z-bar-qt 2026-06-30 03:18:19 +02:00
728bdc85bc fix(clang-tidy/analyzer): resolving false positives
AramJonghu pushed to tidy-warning-fixes at zach/z-bar-qt 2026-06-30 03:08:35 +02:00
944694966b tidy(blobmaterial&circularindicatormanager): warning fixes, readability and modernize headers.
AramJonghu pushed to tidy-warning-fixes at zach/z-bar-qt 2026-06-30 02:10:43 +02:00
1e31e14de8 format(remainder): clang-format remainder of files
658be09da2 fix(buttonrow): restore private specifier removed by clang-format
Compare 2 commits »
AramJonghu pushed to tidy-warning-fixes at zach/z-bar-qt 2026-06-30 02:04:28 +02:00
467e44bb9f tidy&format(all): all files formatted and relevant warnings resolved
fed9372b35 refactor(tickingservice): flatten nested if blocks with early returns
b2cddea636 fix(gpu): use epsilon comparison instead of == for floating-point guards
396825d785 fix(desktopmodel): cast qsizetype to int to suppress -Wshorten-64-to-32
Compare 4 commits »
AramJonghu pushed to tidy-warning-fixes at zach/z-bar-qt 2026-06-30 01:26:26 +02:00
f439456ff4 fix(strokecanvasrenderer): use qreal instead of float in drawHoverCursor
AramJonghu pushed to tidy-warning-fixes at zach/z-bar-qt 2026-06-30 01:22:55 +02:00
4a18edfc78 fix(strokecanvasitem): use qreal instead of float to suppress -Wdouble-promotion
AramJonghu pushed to tidy-warning-fixes at zach/z-bar-qt 2026-06-30 01:18:11 +02:00
4023a2fb01 fix(strokecanvasitem): use qreal instead of float to suppress -Wdouble-promotion
3eecbc16bc perf(lazylistview): collect pending indices and hoist layoutSize cast in updatePolishdbus workaround for session
Compare 2 commits »
AramJonghu pushed to tidy-warning-fixes at zach/z-bar-qt 2026-06-29 23:01:59 +02:00
b939224e9d action secret added so we have push permissions for docker
AramJonghu created pull request zach/z-bar-qt#132 2026-06-29 22:41:35 +02:00
WIP: tidy warning fixes
AramJonghu deleted branch clang-tidy-fixes from zach/z-bar-qt 2026-06-29 22:40:57 +02:00
AramJonghu deleted branch clang-tidy-hotfix from zach/z-bar-qt 2026-06-29 22:40:52 +02:00
AramJonghu created branch tidy-warning-fixes in zach/z-bar-qt 2026-06-29 22:40:35 +02:00
AramJonghu pushed to tidy-warning-fixes at zach/z-bar-qt 2026-06-29 22:40:35 +02:00
644a1e0c78 workflow update; node and docker deps added
AramJonghu pushed to clang-tidy-fixes at zach/z-bar-qt 2026-06-29 22:36:58 +02:00
d9b555ec17 workflow update; node and docker deps added
AramJonghu commented on pull request zach/z-bar-qt#130 2026-06-29 20:31:17 +02:00
update to clang-tidy + workflow improvement cpp build & lint check

Consider a squash commit since there is a lot of noise with all the commits. A single squash commit would reduce the many commit messages with a single more informative commit message.

AramJonghu commented on pull request zach/z-bar-qt#130 2026-06-29 20:19:48 +02:00
update to clang-tidy + workflow improvement cpp build & lint check

I think for consistency and readibility of PRs reasons, I should reserve fixing clang-tidy (and format) for a different PR. That would muddy this PR and add noise.

On further search; we cannot…

AramJonghu pushed to clang-tidy-fixes at zach/z-bar-qt 2026-06-29 19:56:36 +02:00
50e179e0fe adusted workflow to fit new cmakelists
AramJonghu pushed to clang-tidy-fixes at zach/z-bar-qt 2026-06-29 19:49:03 +02:00
25c9979674 Merge branch 'main' into clang-tidy-fixes
7d65578a5f proper VERSION var
f883b3d7fe versioning
Compare 3 commits »
AramJonghu commented on pull request zach/z-bar-qt#130 2026-06-29 11:36:20 +02:00
update to clang-tidy + workflow improvement cpp build & lint check

Certainly possible. Previous implementation was just a wildcard (so all diagnostics were considered errors). We can pick which diagnostics we want as errors, warnings, or info/help.

AramJonghu commented on pull request zach/z-bar-qt#130 2026-06-29 01:39:34 +02:00
update to clang-tidy + workflow improvement cpp build & lint check

@zach Many of the tidy rules are removed and they are not considered errors anymore. I will research further some other day (perhaps when skimming the current tidy warnings in the workflow step)…