@zach you are the goat. I consider the issue closed as per be8b7ae436.
Using globalshortcuts seems to work and the OSD responds properly. One thing of note:
- Brightness cannot be below 1 (or 1%). OLED displays would go completely black. Can this be set somewhere?
Right, I forgot about the global shortcuts. I will try those and report back. Though yea definitely not good to constantly poll ddcutil.
7cf6e5f8a5
Merge pull request '95: Fix light/dark mode mismatch causes preset to not load' (#124) from 95-fix-light-mode-scheme-mismatch into main
I do not really read a todo or expectation for when this was considered ready or satisfactory, only what is implemented currently.
The reason it is there is because the current implementation usually only has a single mode per colorscheme preset. rosepine:dawn only has light mode for example. The current implementation…
Note: I found a bug where if user selects light mode in the settingswindow, but uses dark scheme preset, other UI does not follow. Would have to investigate further on this specific issue.
Is this finished? Since a PR was merged. No branch specified or additional comment. Moved to Review for now.