100 shell autocomplete, type fixes, Pillow deprecation cleanup #101

Merged
zach merged 7 commits from 100-cli-autocompletion into main 2026-05-26 13:10:56 +02:00
Collaborator

Changes

A few changes. Would also like some preferences as some of the current changes could be seen as a forced change.

  • Autocomplete for zshell-cli commands in general. Check here for an example: image.png
    This would apply to all non flag commands. A flag will give autocomplete suggestions once the user inputs a -. Example here:
    image.png
  • Fixed some pyright/ruff type errors
  • Pillow had some deprecated syntax, resolved them.

Preference question

In this current code, the first zshell-cli command auto installs autocompletion and writes (into) two files. While convenient to me, this could be frowned upon that it writes into files without intentional user input. An alternative could be a hint message or a first time zshell-cli prompt to install autocomplete (only once). If this is preferred, I will adjust.

Closes #100

### Changes A few changes. Would also like some preferences as some of the current changes could be seen as a forced change. - Autocomplete for `zshell-cli` commands in general. Check here for an example: ![image.png](/attachments/be4cc84f-2bd5-41bc-be52-73839c37cd02) This would apply to all non flag commands. A flag will give autocomplete suggestions once the user inputs a `-`. Example here: ![image.png](/attachments/f314eb88-491b-481e-8ceb-a8c262f79e67) - Fixed some pyright/ruff type errors - Pillow had some deprecated syntax, resolved them. ### Preference question In this current code, the first zshell-cli command auto installs autocompletion and writes (into) two files. While convenient to me, this could be frowned upon that it writes into files without intentional user input. An alternative could be a hint message or a first time zshell-cli prompt to install autocomplete (only once). If this is preferred, I will adjust. Closes #100
AramJonghu added the enhancement label 2026-05-25 20:09:30 +02:00
AramJonghu self-assigned this 2026-05-25 20:09:30 +02:00
AramJonghu added 4 commits 2026-05-25 20:09:30 +02:00
adding hint if is ran without -- flag
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 11s
Python / lint-format (pull_request) Successful in 26s
Python / test (pull_request) Successful in 45s
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m47s
d0b2a5fc1d
AramJonghu requested review from Inorishio 2026-05-25 20:09:30 +02:00
AramJonghu requested review from zach 2026-05-25 20:09:30 +02:00
Owner

Personally think we should have it as a command like zshell-cli install-completion or similar, and then inform users about it in the project's readme. This is very useful and I like the changes, but I also want the CLI tool to be as unobtrusive as possible. It's really only meant to be used manually by people working on the shell or tool itself.

Personally think we should have it as a command like `zshell-cli install-completion` or similar, and then inform users about it in the project's readme. This is very useful and I like the changes, but I also want the CLI tool to be as unobtrusive as possible. It's really only meant to be used manually by people working on the shell or tool itself.
Author
Collaborator

Ill look into it and make the changes.

Ill look into it and make the changes.
AramJonghu added 1 commit 2026-05-26 09:25:09 +02:00
autocomplete now optional. Includes hint on first command input
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 12s
Python / lint-format (pull_request) Successful in 19s
Python / test (pull_request) Successful in 57s
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m46s
d19eead1f5
AramJonghu added 1 commit 2026-05-26 09:31:03 +02:00
accidental duplicate logic removed
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 11s
Python / lint-format (pull_request) Successful in 23s
Python / test (pull_request) Successful in 48s
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m45s
233ea3efb9
Author
Collaborator

@zach since you did not leave a "review", @ing you instead. Changes are made. I did add a tip if autocomplete is not installed. Should not be of any harm.

@zach since you did not leave a "review", @ing you instead. Changes are made. I did add a tip if autocomplete is not installed. Should not be of any harm.
zach added 1 commit 2026-05-26 13:05:12 +02:00
Merge branch 'main' into 100-cli-autocompletion
Lint & Format (JS/TS) / lint-format (pull_request) Successful in 11s
Python / lint-format (pull_request) Successful in 33s
Python / test (pull_request) Successful in 49s
Lint & Format (Rust) / lint-format (pull_request) Successful in 1m46s
c33d6ae2dd
zach approved these changes 2026-05-26 13:10:44 +02:00
zach merged commit f475e43c54 into main 2026-05-26 13:10:56 +02:00
Sign in to join this conversation.