100 shell autocomplete, type fixes, Pillow deprecation cleanup #101

Merged

zach merged 7 commits from 100-cli-autocompletion into main 2026-05-26 13:10:56 +02:00

Conversation 4 Commits 7 Files Changed 4

+169 -44

AramJonghu commented 2026-05-25 20:09:30 +02:00

Collaborator

Copy Link

Copy Source

Changes

A few changes. Would also like some preferences as some of the current changes could be seen as a forced change.

• Autocomplete for zshell-cli commands in general. Check here for an example:
  This would apply to all non flag commands. A flag will give autocomplete suggestions once the user inputs a -. Example here:
  
• Fixed some pyright/ruff type errors
• Pillow had some deprecated syntax, resolved them.

Preference question

In this current code, the first zshell-cli command auto installs autocompletion and writes (into) two files. While convenient to me, this could be frowned upon that it writes into files without intentional user input. An alternative could be a hint message or a first time zshell-cli prompt to install autocomplete (only once). If this is preferred, I will adjust.

Closes #100

### Changes A few changes. Would also like some preferences as some of the current changes could be seen as a forced change. - Autocomplete for `zshell-cli` commands in general. Check here for an example:  This would apply to all non flag commands. A flag will give autocomplete suggestions once the user inputs a `-`. Example here:  - Fixed some pyright/ruff type errors - Pillow had some deprecated syntax, resolved them. ### Preference question In this current code, the first zshell-cli command auto installs autocompletion and writes (into) two files. While convenient to me, this could be frowned upon that it writes into files without intentional user input. An alternative could be a hint message or a first time zshell-cli prompt to install autocomplete (only once). If this is preferred, I will adjust. Closes #100

image.png

50 KiB

image.png

189 KiB

AramJonghu added the enhancement label 2026-05-25 20:09:30 +02:00

AramJonghu self-assigned this 2026-05-25 20:09:30 +02:00

AramJonghu added 4 commits 2026-05-25 20:09:30 +02:00

initial commit 1c11549811

pyright error fixes. added autocomplete to some commands 17fcf1a02c

pyright/ruff error fixes. Autoinstall check of autocomplete 32acfa6b9f

adding hint if is ran without -- flag d0b2a5fc1d

AramJonghu requested review from Inorishio 2026-05-25 20:09:30 +02:00

AramJonghu requested review from zach 2026-05-25 20:09:30 +02:00

zach commented 2026-05-25 23:59:04 +02:00

Owner

Copy Link

Copy Source

Personally think we should have it as a command like zshell-cli install-completion or similar, and then inform users about it in the project's readme. This is very useful and I like the changes, but I also want the CLI tool to be as unobtrusive as possible. It's really only meant to be used manually by people working on the shell or tool itself.

Personally think we should have it as a command like `zshell-cli install-completion` or similar, and then inform users about it in the project's readme. This is very useful and I like the changes, but I also want the CLI tool to be as unobtrusive as possible. It's really only meant to be used manually by people working on the shell or tool itself.

AramJonghu commented 2026-05-26 06:03:43 +02:00

Author

Collaborator

Copy Link

Copy Source

Ill look into it and make the changes.

Ill look into it and make the changes.

AramJonghu added 1 commit 2026-05-26 09:25:09 +02:00

autocomplete now optional. Includes hint on first command input d19eead1f5

AramJonghu added 1 commit 2026-05-26 09:31:03 +02:00

accidental duplicate logic removed 233ea3efb9

AramJonghu commented 2026-05-26 09:36:55 +02:00

Author

Collaborator

Copy Link

Copy Source

@zach since you did not leave a "review", @ing you instead. Changes are made. I did add a tip if autocomplete is not installed. Should not be of any harm.

@zach since you did not leave a "review", @ing you instead. Changes are made. I did add a tip if autocomplete is not installed. Should not be of any harm.

zach added 1 commit 2026-05-26 13:05:12 +02:00

Merge branch 'main' into 100-cli-autocompletion c33d6ae2dd

zach approved these changes 2026-05-26 13:10:44 +02:00

zach merged commit f475e43c54 into main 2026-05-26 13:10:56 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Inorishio

zach

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No labels enhancement

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

AramJonghu Inorishio zach

No Assignees AramJonghu

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zach/z-bar-qt#101