Launcher carousel is outdated and deserves a refresh. Follows Material Design 3 Hero-ish design. Functionality will be the same as before.
Will be merged once #143 is merged due to singleton naming.
Fixes a crash due to memory leak
Oops.
Related issue
No response
Type
New feature
Tested
Build succeeds
Existing tests pass
Manually verified
Breaking changes?
No response
Checklist
CI passes (format, lint, typecheck)
Clean commits
No new warnings
Docs updated if needed
### What & why
Launcher carousel is outdated and deserves a refresh. Follows [Material Design 3 Hero-ish](https://m3.material.io/components/carousel/specs) design. Functionality will be the same as before.
Will be merged once #143 is merged due to singleton naming.
### Fixes a crash due to memory leak
Oops.
### Related issue
_No response_
### Type
New feature
### Tested
- [x] Build succeeds
- [x] Existing tests pass
- [x] Manually verified
### Breaking changes?
_No response_
### Checklist
- [x] CI passes (format, lint, typecheck)
- [x] Clean commits
- [x] No new warnings
- [x] Docs updated if needed
Carousel dragging with cursor can only be done if you click and drag in between the images. Dragging should be able to be done when click starts on image.
Touch screen behaves the same as above. But as another note; swiping does not accelerate the carousel moving. This makes it quite tedious and slow to drag to find the correct image.
#145 could be included in this PR as it deals with a launcher command.
Other than those notes, wallpapers load consistently (not always snappy, but some files are 20MB+ large). Looks solid otherwise.
A few things of note.
- Carousel dragging with cursor can only be done if you click and drag in between the images. Dragging should be able to be done when click starts on image.
- Touch screen behaves the same as above. But as another note; swiping does not accelerate the carousel moving. This makes it quite tedious and slow to drag to find the correct image.
- #145 could be included in this PR as it deals with a launcher command.
Other than those notes, wallpapers load consistently (not always snappy, but some files are 20MB+ large). Looks solid otherwise.
Carousel dragging with cursor can only be done if you click and drag in between the images. Dragging should be able to be done when click starts on image.
Touch screen behaves the same as above. But as another note; swiping does not accelerate the carousel moving. This makes it quite tedious and slow to drag to find the correct image.
I noticed this too, I just forgot to mention it in the PR. I honestly have no idea how to fix it, haha. Mainly because it's a delegate from QML that is stealing input, while it needs to propagate it to the C++ component underneath.
#145 could be included in this PR as it deals with a launcher command.
I will look into it.
> - Carousel dragging with cursor can only be done if you click and drag in between the images. Dragging should be able to be done when click starts on image.
> - Touch screen behaves the same as above. But as another note; swiping does not accelerate the carousel moving. This makes it quite tedious and slow to drag to find the correct image.
I noticed this too, I just forgot to mention it in the PR. I honestly have no idea how to fix it, haha. Mainly because it's a delegate from QML that is stealing input, while it needs to propagate it to the C++ component underneath.
> - #145 could be included in this PR as it deals with a launcher command.
I will look into it.
> I honestly have no idea how to fix it, haha.
I lied apparently. Fixed in [69c2bfae9d](https://git.zach-dev.cc/zach/z-bar-qt/commit/69c2bfae9d5b7effd44d5a4b810cd74d0da62a83)
Touchscreen dragging does not seem to work in the last revision.
I did not get an answer for an acceleration from dragging the carousel. What do you think of the idea? Especially on touchscreen, but with mouse as well, dragging is tiresome.
Just tested it.
Issue #145 is resolved.
- Touchscreen dragging does not seem to work in the last revision.
I did not get an answer for an acceleration from dragging the carousel. What do you think of the idea? Especially on touchscreen, but with mouse as well, dragging is tiresome.
Acceleration and deceleration works. I was interested about the deceleration. Is it intentionally different from the settings acceleration? For example in Settings->Appearance->Wallpapers, here scrolling is a different motion than the wallpaper carousel.
For the record, touchscreen dragging is not resolved. I am aware this is hard or impossible for you to test, so it is fine to drop this for this PR.
Other than those, approved.
Acceleration and deceleration works. I was interested about the deceleration. Is it intentionally different from the settings acceleration? For example in Settings->Appearance->Wallpapers, here scrolling is a different motion than the wallpaper carousel.
For the record, touchscreen dragging is not resolved. I am aware this is hard or impossible for you to test, so it is fine to drop this for this PR.
Other than those, approved.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
What & why
Launcher carousel is outdated and deserves a refresh. Follows Material Design 3 Hero-ish design. Functionality will be the same as before.
Will be merged once #143 is merged due to singleton naming.
Fixes a crash due to memory leak
Oops.
Related issue
No response
Type
New feature
Tested
Breaking changes?
No response
Checklist
WIP: MD3 wallpaper launcher carouselto Feat: MD3 wallpaper launcher carouselA few things of note.
Other than those notes, wallpapers load consistently (not always snappy, but some files are 20MB+ large). Looks solid otherwise.
I noticed this too, I just forgot to mention it in the PR. I honestly have no idea how to fix it, haha. Mainly because it's a delegate from QML that is stealing input, while it needs to propagate it to the C++ component underneath.
I will look into it.
I lied apparently. Fixed in 69c2bfae9d
Just tested it.
Issue #145 is resolved.
I did not get an answer for an acceleration from dragging the carousel. What do you think of the idea? Especially on touchscreen, but with mouse as well, dragging is tiresome.
I need to figure out how to do it, but yeah sure.
All seems to be working well.
I've no found issues with the wallpaper picker in launcher.
Acceleration and deceleration works. I was interested about the deceleration. Is it intentionally different from the settings acceleration? For example in Settings->Appearance->Wallpapers, here scrolling is a different motion than the wallpaper carousel.
For the record, touchscreen dragging is not resolved. I am aware this is hard or impossible for you to test, so it is fine to drop this for this PR.
Other than those, approved.
I mentioned you in the group chat about why. I don't have the source code for Qt's
Flickabletype to replicate the velocity.