Fix: Proper color scheme preview to avoid watcher creation spam #150

Merged

zach merged 5 commits from fix/proper-scheme-previews into main 2026-08-17 21:01:26 +02:00

Conversation 2 Commits 5 Files Changed 5

+59 -15

zach commented 2026-08-17 14:32:01 +02:00

Owner

Copy Link

Copy Source

What & why

Adds new cli flag to generate subcommand: --preview/-p which prints scheme to stdout and then early returns. This is used in Services/Colors.load().

Adds short versions of existing flags (--image-path -> -i).

The "preview" state on the QML side was lazy and wasn't really a preview at all. It was effectively performing all operations for setting a wallpaper every time currentIndex updated in the wallpaper carousel, most importantly it was writing the ${Paths.state}/scheme.json file every time.

This is okay behavior, but wasteful. Due to how file watchers work by "attaching" to a specific file, when said file is overwritten by an atomic write (which we always use), then the original file no longer exists and the current watcher needs to be killed only for a new one to be spawned to watch the new file.

This PR solves this by loading the color scheme through stdout and only once the user sets/accepts the selected wallpaper will it write the scheme file, and if the user cancels then no write will happen.

Related issue

No response

Type

Bug fix

Tested

• Build succeeds
• Existing tests pass
• Manually verified

Breaking changes?

No response

Checklist

• CI passes (format, lint, typecheck)
• Clean commits
• No new warnings
• Docs updated if needed

### What & why Adds new cli flag to `generate` subcommand: `--preview`/`-p` which prints scheme to `stdout` and then early returns. This is used in `Services/Colors.load()`. Adds short versions of existing flags (`--image-path` -> `-i`). The "preview" state on the QML side was lazy and wasn't really a preview at all. It was effectively performing all operations for setting a wallpaper every time `currentIndex` updated in the wallpaper carousel, most importantly it was writing the `${Paths.state}/scheme.json` file every time. This is okay behavior, but wasteful. Due to how file watchers work by "attaching" to a specific file, when said file is overwritten by an atomic write (which we always use), then the original file no longer exists and the current watcher needs to be killed only for a new one to be spawned to watch the new file. This PR solves this by loading the color scheme through `stdout` and only once the user sets/accepts the selected wallpaper will it write the scheme file, and if the user cancels then no write will happen. ### Related issue _No response_ ### Type Bug fix ### Tested - [x] Build succeeds - [x] Existing tests pass - [x] Manually verified ### Breaking changes? _No response_ ### Checklist - [ ] CI passes (format, lint, typecheck) - [x] Clean commits - [x] No new warnings - [x] Docs updated if needed

zach added 1 commit 2026-08-17 14:32:01 +02:00

proper color scheme preview to avoid watcher creation spam 177b0f319c

zach requested review from AramJonghu 2026-08-17 14:33:09 +02:00

zach requested review from Inorishio 2026-08-17 14:33:09 +02:00

zach added 1 commit 2026-08-17 16:54:52 +02:00

Merge branch 'main' into fix/proper-scheme-previews c35e73886a

zach added 1 commit 2026-08-17 18:02:23 +02:00

Merge branch 'main' into fix/proper-scheme-previews 97c48d03f4

zach added 1 commit 2026-08-17 18:46:41 +02:00

Merge branch 'main' into fix/proper-scheme-previews de55b5f1e4

Inorishio commented 2026-08-17 20:55:07 +02:00

Collaborator

Copy Link

Copy Source

Works perfectly 😇

Works perfectly 😇

zach added 1 commit 2026-08-17 21:01:17 +02:00

Merge branch 'main' into fix/proper-scheme-previews 78c0a6fdfc

zach merged commit dfc203f905 into main 2026-08-17 21:01:26 +02:00

zach deleted branch fix/proper-scheme-previews 2026-08-17 21:01:26 +02:00

AramJonghu reviewed 2026-08-17 21:01:52 +02:00

AramJonghu left a comment

Collaborator

Copy Link

Copy Source

Reviewed python code. lgtm.

Reviewed python code. lgtm.

Sign in to join this conversation.

Reviewers

No Reviewers

Inorishio

AramJonghu

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

AramJonghu Inorishio zach

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zach/z-bar-qt#150