Bar entries rework in settings #80

2026-05-05T12:16:12+02:00

zach commented

2026-05-05 12:16:12 +02:00

Changes how bar entries are displayed in the settings window. Now uses regular buttons to toggle their visibility, but removes the ability to move the widgets.

zach added 2 commits 2026-05-05 12:16:12 +02:00

start of rework e4113994dc

end of rework, uses horizontal icon buttons instead of drag handlers and vertical views 8fa447c63d

AramJonghu requested review from AramJonghu 2026-05-05 18:32:51 +02:00

AramJonghu requested changes 2026-05-05 18:48:43 +02:00

AramJonghu left a comment

If there was an issue tied to this, I could check on what features I should look at.

What I found.

What works

Entries remove and insert modules correctly.
Entries are in order of what the bar shows.

What is missing (in my eyes)

I cannot move the modules (or drag) to a specific place as I would before. Looking at the code, this feature is removed it seems.
A subtext that shows what the module is, apart from selecting and/or deselecting. A hover text could resolve that by hovering over the setting with the cursor. The icons are not descriptive enough (hyprsunset icon for example).

What seems broken

The WiFi module specifically looks broken. I made sure to build from scratch, removing all traces of zshell from /etc/... and /usr/etc (since on artix, it builds into /usr/etc, which I then copy to the correct directory). Screenshot provided of how the WiFi module looks broken on my end.
Is the WiFi module supposed to have an interface itself? Like what connections there are and enabling/disabling wifi?

If there was an issue tied to this, I could check on what features I should look at. What I found. ## What works - [x] Entries remove and insert modules correctly. - [x] Entries are in order of what the bar shows. ## What is missing (in my eyes) - [ ] I cannot move the modules (or drag) to a specific place as I would before. Looking at the code, this feature is removed it seems. - [ ] A subtext that shows what the module is, apart from selecting and/or deselecting. A hover text could resolve that by hovering over the setting with the cursor. The icons are not descriptive enough (hyprsunset icon for example). ## What seems broken - [ ] The WiFi module specifically looks broken. I made sure to build from scratch, removing all traces of zshell from `/etc/...` and `/usr/etc` (since on artix, it builds into `/usr/etc`, which I then copy to the correct directory). Screenshot provided of how the WiFi module looks broken on my end. - [ ] Is the WiFi module supposed to have an interface itself? Like what connections there are and enabling/disabling wifi? ![image.png](/attachments/bb6a98cf-d3b0-4204-9b4c-c407471d3fe1)

image.png

3.7 MiB

AramJonghu commented

2026-05-05 18:50:07 +02:00

With the last part, I mean that there is no hover state for the WiFi module, nor is it clickable on my end.

zach commented

2026-05-05 18:56:44 +02:00

It's mainly for you to look at the way the buttons are now. I did mention in the PR message that drag-and-dropping widgets has been removed, that is intentional due to that I do not want to support dynamic popout positioning other than for certain ones that need it (e.g. tray menus.) Daivin mentioned adding tooltips to the buttons as well, I find tooltips to be ugly and generally a clunky UX, but I also think I wouldn't be able to fit the names of the widgets into the buttons with how they are now, so I will need to think of something.

As for the wifi module it is not something I have worked on for months now, because I still need you and Daivin to look into it for me, seeing as I do not have wifi.

It's mainly for you to look at the way the buttons are now. I did mention in the PR message that drag-and-dropping widgets has been removed, that is intentional due to that I do not want to support dynamic popout positioning other than for certain ones that need it (e.g. tray menus.) Daivin mentioned adding tooltips to the buttons as well, I find tooltips to be ugly and generally a clunky UX, but I also think I wouldn't be able to fit the names of the widgets into the buttons with how they are now, so I will need to think of something. As for the wifi module it is not something I have worked on for months now, because I still need you and Daivin to look into it for me, seeing as I do not have wifi.

AramJonghu commented

2026-05-05 19:22:32 +02:00

I'm not sure how I missed the clearly worded "move" in the OP...

Should this PR then not be delayed until a resolution is added for at least the tooltips?

About the dynamic popout positioning, what about if I already moved a module? That would be a config exclusive then?

And yea, @Inorishio , please fix WiFi :).

I'm not sure how I missed the clearly worded "move" in the OP... Should this PR then not be delayed until a resolution is added for at least the tooltips? About the dynamic popout positioning, what about if I already moved a module? That would be a config exclusive then? And yea, @Inorishio , please fix WiFi :).

zach added 1 commit 2026-05-08 19:27:41 +02:00

labels instead of icons for bar entries bcc75abc54

zach commented

2026-05-08 19:31:17 +02:00

I added labels instead of icons now.

Widgets will remain to be movable using the config file but it isn't supported, so will cause unintended behavior with popouts and such.

I added labels instead of icons now. Widgets will remain to be movable using the config file but it isn't supported, so will cause unintended behavior with popouts and such.

👍 1

zach merged commit 836b92cc5f into main

2026-05-08 19:31:38 +02:00

zach deleted branch settings-bar-entries-rework

2026-05-09 00:13:01 +02:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zach/z-bar-qt#80