I personally think we shouldn't default to something here. Raising an exception would be better if the requested scheme is not found, maybe write exception trace to log file too. This is because the condition on line 601 should never return true and if it does then it means we are calling it incorrectly from QML/CLI.
Note: I found a bug where if user selects light mode in the settingswindow, but uses dark scheme preset, other UI does not follow. Would have to investigate further on this specific issue.
Pro…
No, it is not. The PR that merged had nothing to do with this.
Is there a goal in mind before this PR is "ready for review"?
Yeah, I wrote it in OP. There's no point in having you both review this PR when I am far from done.
3f5cc2de07
MaterialIcon opsz clamp, UPower popout and widget changes, improved SysTray hover detection logic
First for sure IMO. I believe anything "automatic" like that should be with direct consent from the user.
We can have visual feedback when the user hasn't selected a light mode preset, such as…
I'd be down for that, yeah. We would need a way to fetch CalDAV calendars, though, since it would not be robust in pure JS. I tried looking around a bit for any libraries we could use directly but…