tidy, format, and resolving tidy warnings #132

Merged

zach merged 26 commits from tidy-warning-fixes into main 2026-06-30 14:46:39 +02:00

Conversation 3 Commits 26 Files Changed 96

+4690 -4120

AramJonghu commented 2026-06-29 22:41:35 +02:00

Collaborator

Copy Link

Copy Source

Goal

Test & adjust newly updated .clang-tidy rules. Resolve all user fixable warnings/diagnostics. Also format all cpp and hpp files (many were not formatted).

What changed

• All files are formatted, some snippits have format disabled due to less readable format.
• Resolve warnings where possible, improved consistency by a lot.
• Remove/adjust format and tidy rules wherever needed. Some rules were too agressive or not to our liking.
• Some snippits had improvements left on the table. Some examples are tickingservice.cpp nesting reduction or strokecanvasrenderer.cpp qreal instead of float values.
• CI/CD ignores compile errors that are not related to user written code.
• ci-image.yml adjustment requiring node and docker with registry token to access docker build.

Caution

• Functionality should not change, but verifying if things messed up is important due to large change overal (excluding formatting as well).
• Take into account other PR's, conflicts could occur.

### Goal Test & adjust newly updated `.clang-tidy` rules. Resolve all user fixable warnings/diagnostics. Also format all cpp and hpp files (many were not formatted). ### What changed - All files are formatted, some snippits have format disabled due to less readable format. - Resolve warnings where possible, improved consistency by a lot. - Remove/adjust format and tidy rules wherever needed. Some rules were too agressive or not to our liking. - Some snippits had improvements left on the table. Some examples are `tickingservice.cpp` nesting reduction or `strokecanvasrenderer.cpp` qreal instead of float values. - CI/CD ignores compile errors that are not related to user written code. - `ci-image.yml` adjustment requiring node and docker with registry token to access docker build. ### Caution - Functionality should not change, but verifying if things messed up is important due to large change overal (excluding formatting as well). - Take into account other PR's, conflicts could occur.

AramJonghu added 1 commit 2026-06-30 01:22:55 +02:00

fix(strokecanvasitem): use qreal instead of float to suppress -Wdouble-promotion 4a18edfc78

AramJonghu force-pushed tidy-warning-fixes from 4023a2fb01 to 4a18edfc78 2026-06-30 01:22:55 +02:00 Compare

AramJonghu added 1 commit 2026-06-30 01:26:26 +02:00

fix(strokecanvasrenderer): use qreal instead of float in drawHoverCursor f439456ff4

AramJonghu added 4 commits 2026-06-30 02:04:28 +02:00

fix(desktopmodel): cast qsizetype to int to suppress -Wshorten-64-to-32 396825d785

fix(gpu): use epsilon comparison instead of == for floating-point guards b2cddea636

refactor(tickingservice): flatten nested if blocks with early returns fed9372b35

tidy&format(all): all files formatted and relevant warnings resolved 467e44bb9f

AramJonghu added 2 commits 2026-06-30 02:10:43 +02:00

fix(buttonrow): restore private specifier removed by clang-format 658be09da2

format(remainder): clang-format remainder of files 1e31e14de8

AramJonghu added 1 commit 2026-06-30 03:08:35 +02:00

tidy(blobmaterial&circularindicatormanager): warning fixes, readability and modernize headers. 944694966b

AramJonghu added 1 commit 2026-06-30 03:18:19 +02:00

fix(clang-tidy/analyzer): resolving false positives 728bdc85bc

AramJonghu added 1 commit 2026-06-30 03:18:48 +02:00

leftover format file d4e4152bdc

AramJonghu added 2 commits 2026-06-30 03:27:05 +02:00

missing commas clang-tidy e347671edd

unused nolint dcc535d213

AramJonghu added 2 commits 2026-06-30 03:38:44 +02:00

clang-tidy: reordering 532e5a0a03

fix(hyprextras): false flag recursion 87c9f85ac7

AramJonghu added 1 commit 2026-06-30 03:44:40 +02:00

CI/CD: updated cpp to reduce false flags, focus on dev tidy check 49a65becff

AramJonghu added 1 commit 2026-06-30 03:54:51 +02:00

CI/CD: updated, should not stop the check now due to diagnostic demotion 25e1610e2b

AramJonghu added 1 commit 2026-06-30 04:02:26 +02:00

CI/CD: updated, researched other CI/CD implementations b8f79c51ae

AramJonghu added 1 commit 2026-06-30 04:17:54 +02:00

CI/CD: testing warnings as errors for CI/CD only d2368c8c10

AramJonghu added 1 commit 2026-06-30 04:27:51 +02:00

CI/CD: revert 1cdcecae68

AramJonghu added 1 commit 2026-06-30 04:36:28 +02:00

CI/CD: attempt only user tidy warnings 3c9df82594

AramJonghu added 1 commit 2026-06-30 04:42:42 +02:00

force harmless lint warning to check ci/cd 85944ec966

AramJonghu added 1 commit 2026-06-30 04:49:59 +02:00

fix&revert(qalculator): unassigned this to calculator pointer fixed, revert of succesful test 45350210cc

AramJonghu self-assigned this 2026-06-30 05:07:30 +02:00

AramJonghu added the enhancement label 2026-06-30 05:07:35 +02:00

AramJonghu marked the pull request as ready for review 2026-06-30 05:07:42 +02:00

AramJonghu requested review from zach 2026-06-30 05:07:42 +02:00

AramJonghu changed title from tidy warning fixes to tidy, format, and resolving tidy warnings 2026-06-30 05:08:34 +02:00

AramJonghu commented 2026-06-30 12:29:50 +02:00

Author

Collaborator

Copy Link

Copy Source

One finding I had is that when building and running feat/settings-revamp branch, config file adds anim. This seems to cause issues on main and tidy-warning-fixes.

On request, I will remove (most) comments in the codebase.

One finding I had is that when building and running `feat/settings-revamp` branch, config file adds anim. This seems to cause issues on `main` and `tidy-warning-fixes`. On request, I will remove (most) comments in the codebase.

zach commented 2026-06-30 13:09:00 +02:00

Owner

Copy Link

Copy Source

config file adds anim.

What does this mean?

> config file adds anim. What does this mean?

AramJonghu commented 2026-06-30 14:17:19 +02:00

Author

Collaborator

Copy Link

Copy Source

That is unclear indeed.

I wanted to illustrate that I noticed that building feature branch adds/changes config file. The new additions seemingly break compatibility with main and tidy-warning-fixes.

anim refers to the added appearance { anim { block in config.json.

That is unclear indeed. I wanted to illustrate that I noticed that building feature branch adds/changes config file. The new additions seemingly break compatibility with main and tidy-warning-fixes. anim refers to the added `appearance { anim {` block in `config.json`.

zach merged commit 60831de7c5 into main 2026-06-30 14:46:39 +02:00

zach deleted branch tidy-warning-fixes 2026-06-30 14:46:47 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

zach

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No labels enhancement

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

AramJonghu Inorishio zach

No Assignees AramJonghu

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zach/z-bar-qt#132