zach/z-bar-qt
1
1
Fork 0
Code Issues 23 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

fix blobs dirty tracking #87

Merged
AramJonghu merged 20 commits from blob-testing into main 2026-05-19 23:18:58 +02:00
Conversation 5 Commits 20 Files Changed 33
+1724 -1770
zach commented 2026-05-19 04:57:35 +02:00
Owner
Copy Link
Copy Source

Blobs were incorrectly calculating size-change deltas by only accounting for the previous and current frame. Now it correctly accumulates deltas over multiple frames which fixes background "desync".

Commit messages are terrible, I know.

Blobs were incorrectly calculating size-change deltas by only accounting for the previous and current frame. Now it correctly accumulates deltas over multiple frames which fixes background "desync". Commit messages are terrible, I know.
zach added 11 commits 2026-05-19 04:57:35 +02:00
update blobs f89236f51e
update blobs 0a84c822d5
update blobs 5eb32fc30c
revert blobs cb1df5078b
update blobs c060be79e8
update blobs 3d2fc0a3b1
update blobs 8fba953f52
revert blobs 015ee61885
update blobs 8c22855dd8
Revert "update blobs" 550630feaa 
This reverts commit 8c22855dd8.
update blobs
Format (JS/TS) / format (pull_request) Failing after 8s
Details
Lint (JS/TS) / lint (pull_request) Failing after 10s
Details
Lint (Python) / lint (pull_request) Failing after 29s
Details
Lint (Rust) / lint (pull_request) Failing after 1m34s
Details
d0e696c681
zach requested review from AramJonghu 2026-05-19 05:00:25 +02:00
zach requested review from Inorishio 2026-05-19 05:00:25 +02:00
zach added 1 commit 2026-05-19 07:09:45 +02:00
fix settings background desync
Format (JS/TS) / format (pull_request) Failing after 6s
Details
Lint (JS/TS) / lint (pull_request) Failing after 11s
Details
Lint (Python) / lint (pull_request) Failing after 25s
Details
Lint (Rust) / lint (pull_request) Failing after 1m33s
Details
3bd9444e2f
zach added 1 commit 2026-05-19 08:24:10 +02:00
fix some backgrounds, now attaching to wrappers rather than panel itself most of the time
Format (JS/TS) / format (pull_request) Failing after 7s
Details
Lint (JS/TS) / lint (pull_request) Failing after 10s
Details
Lint (Python) / lint (pull_request) Failing after 19s
Details
Lint (Rust) / lint (pull_request) Failing after 1m35s
Details
db7a822caf
zach added 1 commit 2026-05-19 08:30:35 +02:00
move search index file to correct place
Format (JS/TS) / format (pull_request) Failing after 7s
Details
Lint (JS/TS) / lint (pull_request) Failing after 10s
Details
Lint (Python) / lint (pull_request) Failing after 19s
Details
Lint (Rust) / lint (pull_request) Failing after 1m30s
Details
405825518a
zach added 1 commit 2026-05-19 08:43:57 +02:00
add the drawing popout background
Format (JS/TS) / format (pull_request) Failing after 6s
Details
Lint (JS/TS) / lint (pull_request) Failing after 11s
Details
Lint (Python) / lint (pull_request) Failing after 19s
Details
Lint (Rust) / lint (pull_request) Failing after 1m36s
Details
362b7bb8c2
zach added 1 commit 2026-05-19 10:04:09 +02:00
hopefully increase drawing performance
Format (JS/TS) / format (pull_request) Failing after 6s
Details
Lint (JS/TS) / lint (pull_request) Failing after 15s
Details
Lint (Python) / lint (pull_request) Failing after 18s
Details
Lint (Rust) / lint (pull_request) Failing after 1m32s
Details
b20767c702
zach added 1 commit 2026-05-19 15:39:04 +02:00
select part of wallpaper to show
Format (JS/TS) / format (pull_request) Failing after 7s
Details
Lint (JS/TS) / lint (pull_request) Failing after 12s
Details
Lint (Python) / lint (pull_request) Failing after 20s
Details
Lint (Rust) / lint (pull_request) Failing after 1m40s
Details
b6ad180b6a
zach added 1 commit 2026-05-19 16:10:05 +02:00
hide notification content on lockscreen, toggleable
Format (JS/TS) / format (pull_request) Failing after 7s
Details
Lint (JS/TS) / lint (pull_request) Failing after 11s
Details
Lint (Python) / lint (pull_request) Failing after 18s
Details
Lint (Rust) / lint (pull_request) Failing after 1m32s
Details
9c6a1ce1a4
zach added 1 commit 2026-05-19 16:15:43 +02:00
cleanup unneeded logging
Format (JS/TS) / format (pull_request) Failing after 6s
Details
Lint (JS/TS) / lint (pull_request) Failing after 11s
Details
Lint (Python) / lint (pull_request) Failing after 19s
Details
Lint (Rust) / lint (pull_request) Failing after 1m34s
Details
62ec1b9f33
AramJonghu requested changes 2026-05-19 16:45:24 +02:00
Dismissed
AramJonghu left a comment
Collaborator
Copy Link
Copy Source

Notification feedback in #88 .

The wallpaper picker in settings has nice changes, but introduces some bugs. For example:

  • When changing wallpaper: then clicking (or dragging) the viewable region, it sometimes reverts to the previous wallpaper. Only way to reset this is to select a different wallpaper and try again.
  • When changing region of wallpaper with scroll wheel, it seems to not be updated until the actual window has been moved. This is also buggy as it sometimes reverts to the old wallpaper instead.
  • The wallpaper applying has a weird bounce effect from old to new wallpaper, including when sizing the viewable window.
  • Multi monitor support missing (I assume not intended to be included).

Could point 1 and 2 be resolved with an "apply wallpaper" button? This could simplify the application method drastically without relying on an end of movement call of the sort.

As for multi monitor, this could be a separate issue to resolve as I presume many things need to be taken into account.

Notification feedback in #88 . The wallpaper picker in settings has nice changes, but introduces some bugs. For example: - When changing wallpaper: then clicking (or dragging) the viewable region, it sometimes reverts to the previous wallpaper. Only way to reset this is to select a different wallpaper and try again. - When changing region of wallpaper with scroll wheel, it seems to not be updated until the actual window has been moved. This is also buggy as it sometimes reverts to the old wallpaper instead. - The wallpaper applying has a weird bounce effect from old to new wallpaper, including when sizing the viewable window. - Multi monitor support missing (I assume not intended to be included). Could point 1 and 2 be resolved with an "apply wallpaper" button? This could simplify the application method drastically without relying on an end of movement call of the sort. As for multi monitor, this could be a separate issue to resolve as I presume many things need to be taken into account.
zach commented 2026-05-19 16:53:09 +02:00
Author
Owner
Copy Link
Copy Source

Both 1 and 2 are related to how I apply wallpapers and I will need to make changes to the conditional statement of when the wallpaper should change between wallpapers. Simplified, the wallpapers applying works by loading both the previous and current wallpapers into memory to be able to achieve a relatively seamless switch between the two, otherwise the image will kinda just "pop" in whenever it feels like loading.

If you're interested, the faulty logic is

z-bar-qt/Modules/Wallpaper/WallBackground.qml Lines 41 to 47 in 62ec1b9f33
function update(): void {
if (source === root.source) {
root.current = this;
} else {
source = root.source;
}
}

Both 1 and 2 are related to how I apply wallpapers and I will need to make changes to the conditional statement of when the wallpaper should change between wallpapers. Simplified, the wallpapers applying works by loading both the previous and current wallpapers into memory to be able to achieve a relatively seamless switch between the two, otherwise the image will kinda just "pop" in whenever it feels like loading. If you're interested, the faulty logic is https://git.zach-dev.cc/zach/z-bar-qt/src/commit/62ec1b9f334cba7cb7e85196a0e27970640e0c78/Modules/Wallpaper/WallBackground.qml#L41-L47
👍 1
zach added 1 commit 2026-05-19 22:12:42 +02:00
wallpaper now uses Image (hopefully temporarily)
Format (JS/TS) / format (pull_request) Failing after 7s
Details
Lint (JS/TS) / lint (pull_request) Failing after 10s
Details
Lint (Python) / lint (pull_request) Failing after 19s
Details
Lint (Rust) / lint (pull_request) Failing after 1m36s
Details
24d5584b98
zach commented 2026-05-19 22:15:00 +02:00
Author
Owner
Copy Link
Copy Source

24d5584b98 fixes the image swapping to previous wallpaper when adjusting crop range.

I should mention that the crop region not updating after wheel input is intentional, because that would cause unneeded image reloads. Will probably add dedicated save button though.

[24d5584b98](https://git.zach-dev.cc/zach/z-bar-qt/commit/24d5584b9828b8f2c0a8778b92cc98afc19e6a57) fixes the image swapping to previous wallpaper when adjusting crop range. I should mention that the crop region not updating after wheel input is intentional, because that would cause unneeded image reloads. Will probably add dedicated save button though.
AramJonghu commented 2026-05-19 22:20:48 +02:00
Collaborator
Copy Link
Copy Source

It is resolved indeed.

It is resolved indeed.
AramJonghu approved these changes 2026-05-19 22:31:30 +02:00
AramJonghu merged commit ceca949535 into main 2026-05-19 23:18:58 +02:00
zach deleted branch blob-testing 2026-05-20 04:44:13 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Inorishio
AramJonghu
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AramJonghu Inorishio zach
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zach/z-bar-qt#87